Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planning issue . #17

Open
2 tasks done
sagarpreet-chadha opened this issue Jan 18, 2019 · 8 comments
Open
2 tasks done

Planning issue . #17

sagarpreet-chadha opened this issue Jan 18, 2019 · 8 comments

Comments

@sagarpreet-chadha
Copy link
Collaborator

sagarpreet-chadha commented Jan 18, 2019

Task List ⭐️ :

  • 1. A spec for describing the precision of location data in human terms

    • this wouldn't need to be incredibly formal, but we would basically try to write out a very precise and clear description of the role LBL fulfills, abstractly. It could include very clear examples of how location is blurred and how much precision it "degrades" for each level. Does this make sense? [ solved in Revamped Architecture . #65 ]
  • 2. A utility library for filtering locations to a specific precision level

    • this would be a mini sub-node module broken out of LBL that could be re-used in LBLD, and also in other apps, that would just do the conversions - no UI or geocoding or anything! This should be pretty easy and could have a set of tests to demonstrate how it works (that could overlap a lot with the spec task above)
@sagarpreet-chadha
Copy link
Collaborator Author

@jywarren ...lets add here 😄 !

@sagarpreet-chadha
Copy link
Collaborator Author

sagarpreet-chadha commented Feb 4, 2019

Leaflet Blurred Location Display (LBLD), a library for displaying collections of locations of variable precision

  • establish a simple way to instantiate individual locations and collections (based on other Leaflet libraries)
  • implement changes to have the library read from the plots2 API as a default and display locations accordingly in LBLD based on zoom level
  • define a source URL parameter to point the library at the API
  • document how to connect it to the parent app, as modeled at https://github.com/publiclab/inline-markdown-editor/
  • explore heatmap or aggregate means of displaying locations that, for example, fall in the same grid square, using varying shades to indicate density
  • explore above heatmap display (configurable with a constructor parameter) with ability to click on a grid square to expose a list of points within that square
  • set up gh-pages demo
  • publish on NPM --- to be done by Jeff :)
  • integrate with PublicLab.org and troubleshoot
  • publish blog post introducing the library

A utility library for filtering locations to a specific precision level for use in Leaflet Blurred Location (LBL)

  • as a self-contained, tested node module that is included into LBL
  • determine input types and output formats and develop examples to be used in both tests and documentation
  • integrate the module into LBLD, and also in other apps
  • the module would just do conversions - no UI or geocoding
  • [This is not part of this library : https://github.com/limit zoom level of map ?  blurred-location#3] use the module to implement an option in LBL to limit map input to a precision range, with { max: 14, min: 4 } (i.e. the map would not zoom outside that range nor would coordinates generated fall outside that range of precisions)

@jywarren
Copy link
Member

jywarren commented Feb 20, 2019

Looking great!

  • Let's write tests that assert the markers are shown or hidden as in the new example code!
  • let's separate out the UI code like popup code from the data management code using require()
  • let's clarify what happens when local static data AND remote url are both provided, or move to do only one or the other per layer
  • Let's make a demo of switching between shading and markers modes using a toggle (later when we're ready!) [Done in Revamped Architecture . #65 ]

How do these sound?

@jywarren
Copy link
Member

jywarren commented Feb 20, 2019

Let's also

  • standardize the method names returned by the constructor function to be more readable and clear
  • make some functions like getMarkersOfPrecision(int) and filterCoordinatesToPrecison(int)

@jywarren
Copy link
Member

jywarren commented Apr 3, 2019

Hi @sagarpreet-chadha could you update these checkboxes so I can get synced up about progress? Thank you so much!!!

@sagarpreet-chadha
Copy link
Collaborator Author

@jywarren ...done 👍 !

@jywarren
Copy link
Member

OK, we're almost there -- can you check off items again? thank you!!!

@sagarpreet-chadha
Copy link
Collaborator Author

Done 👍 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants