Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step thumbnail previews generate for non-final steps #1826

Open
jywarren opened this issue Feb 27, 2021 · 3 comments
Open

Add step thumbnail previews generate for non-final steps #1826

jywarren opened this issue Feb 27, 2021 · 3 comments
Labels

Comments

@jywarren
Copy link
Member

I think the previews are being generated for each step, which may be slowing things down a lot. Can someone else try to confirm?

Screenshot_20210227-144111_Chrome

See how the previews correspond to the 2nd to last step and not the last step?

@jywarren jywarren added the bug label Feb 27, 2021
@vivek-30
Copy link

@jywarren sir, i tried this. But strange, i am not facing any such issue 🤔 . in my case only the last step preview get generated.
btw are you talking about initial rendering of a step right? or may be i have interpreted this issue wrongly.

@vivek-30
Copy link

Rather when we delete a step then this kind of rendering starts.
Is this are you taking about?

@jywarren
Copy link
Member Author

jywarren commented Mar 3, 2021

Hm, I wonder if this happened because i added intermediate steps, and changed things several times. This would be perfect for a full-stack UI test to simulate the whole sequence of interactions...

What i saw was that each step also regenerated the thumbnail previews, but if you waited long enough, the final step would generate them too. But it was wasted effort to make thumbnails for any but the final step!

Maybe opening the Insert Step tool caused some cross-wiring of the listeners for generating thumbnails?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants