Add filter button for recent contributors' list

[Rishabh570]

Currently, there is no filter option on the recent contributors' list. There can be some options allowing the user to arrange the list according to his needs.

The filter should be based on,

• alphabetical,
• most recent contributors first.

There can be other filters also which can be implemented later...suggestions are welcome :)

[jywarren]

This is awesome and perhaps we could modify fetchAllRecentMonthCommits() to be generically fetchAllCommitsForPeriod(org, repos, queryTime, start, end)?

community-toolbox/src/utils/recentContribsUtil.js

Lines 36 to 40 in 30dd907

	// Fetches recent month commits for top 10 repositories
	function fetchAllRecentMonthCommits(org, repos, queryTime) {
	let results = [];
	let commitersSet = new Set([]);
	let timeToday = (new Date).getTime();

@gauravano was interested in being able to select the past 2 months of recent contributors in our check-ins (publiclab/plots2#5627). This might be a relatively easy way to expand this functions use for arbitrary time periods.

Thanks @Rishabh570 -- Community Toolbox continuing to be super useful!!!

[Rishabh570]

Yes, it can be expanded to include past X months' commits and this goes very well with the topic of this issue...I'll include it.

[Rishabh570]

So, I'm planning to do a followup refactor work after my already open PRs get merged. This will make it convenient for writing tests & making the logic of recent contributors flexible and for reading the code generally...Currently, I'm looking at the utils/ folder as a place which needs to be refactored the most as it contains most of the logic...Here's how I think the structure would look like,

I guess we should get done with this refactoring work before we work on making the logic of recent contributors flexible (& most probably providing a filter for past 1, 2 and maybe 3 months).

What do you think?

[jywarren]

I think that sounds fine! The basic 1 month sounds good and you're probably right that some more code reorganization is a good early investment!

…

On Thu, Jun 20, 2019 at 11:45 AM Rishabh Rawat ***@***.***> wrote: So, I'm planning to do a followup refactor work after my already open PRs get merged. This will make it convenient for writing tests & making the logic of recent contributors flexible and for reading the code generally...Currently, I'm looking at the utils/ folder as a place which needs to be refactored the most as it contains most of the logic...Here's how I think the structure would look like, [image: Screenshot from 2019-06-20 21-05-01] <https://user-images.githubusercontent.com/25483260/59862201-fb7f0700-939f-11e9-82c2-880325e6b0b7.png> I guess we should get done with this refactoring work before we work on making the logic of recent contributors flexible (& most probably providing a filter for past 1, 2 and maybe 3 months). What do you think? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#202?email_source=notifications&email_token=AAAF6J4WMH2FCVSEN7WI3ELP3OQV3A5CNFSM4HP43RDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYFZ5KI#issuecomment-504077993>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J4PL7QWYLHXYMLNPN3P3OQV3ANCNFSM4HP43RDA> .

[Rishabh570]

I've been working on the recent contributors' section's logic for the past couple days and most of the logic part is almost done. Here's a quick GIF showing the changes,

The main things that are remaining on this are,

• Enhancing the UI a bit of the dropdowns list present,
• Showing the status of the Show option alongside so that people can easily notice the time period for which the data is shown

@publiclab/reviewers @jywarren Please take a look, is there anything more which needs to be there in this filter options bar?

@gauravano Will this resolve the problem of looking for contributors' data for previous X months, the one you were discussing in the check-in?