Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pigeons deserialization of NFFT does not work #316

Closed
dominic-chang opened this issue Sep 12, 2023 · 1 comment
Closed

Pigeons deserialization of NFFT does not work #316

dominic-chang opened this issue Sep 12, 2023 · 1 comment

Comments

@dominic-chang
Copy link
Contributor

dominic-chang commented Sep 12, 2023

Deserialization of Pigeons.jl checkpoints with NFFT plans causes a segmentation fault upon visibility evaluations. This can be fixed by dispatching off the Serialization.deserialize function and reconstructing the FFT plan.

using Serialization
using Comrade

function Serialization.deserialize(s::AbstractSerializer, type::Type{<:Comrade.NUFTCache{<:Comrade.ObservedNUFT,P,M,PI,I}}) where {P,M,PI,I}

    alg = Serialization.deserialize(s)
    _ = Serialization.deserialize(s)
    phase = Serialization.deserialize(s)
    pulse = Serialization.deserialize(s)
    img = Serialization.deserialize(s)

    newplan = Comrade.plan_nuft(alg, img)
    return Comrade.NUFTCache(alg, newplan, phase, pulse, img)
end
@ptiede
Copy link
Owner

ptiede commented Oct 29, 2023

Fixed in VLBISkyModels

@ptiede ptiede closed this as completed Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants