Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wings v1.11.11 does not respect the egg file denylist thoroughly #5042

Open
3 tasks done
itsvic-dev opened this issue Mar 25, 2024 · 0 comments · May be fixed by pterodactyl/wings#183
Open
3 tasks done

Wings v1.11.11 does not respect the egg file denylist thoroughly #5042

itsvic-dev opened this issue Mar 25, 2024 · 0 comments · May be fixed by pterodactyl/wings#183
Labels
bug Something that's not working as it's intended to be.

Comments

@itsvic-dev
Copy link

Current Behavior

  • Wings allows you to download and delete a denylisted file.
  • Wings does not allow you to copy, rename, edit or upload a denylisted file.
  • Wings allows you to overwrite a denylisted file by downloading it from a URL.
  • Wings does not impose any denylist restrictions on SFTP.

Expected Behavior

  • Wings should not allow you to do any operation on denylisted files over the REST API.
  • Wings should not allow you to do any operation on denylisted files over SFTP.

Steps to Reproduce

  1. Edit an egg to add a file to its denylist.
  2. Try to download the denylisted file - it's allowed.
  3. Try to rename or copy the denylisted file - it's blocked.
  4. Try to delete the denylisted file - it's allowed.
  5. Try doing anything to the file over SFTP - it's allowed.

Panel Version

Not applicable

Wings Version

1.11.11

Games and/or Eggs Affected

No response

Docker Image

No response

Error Logs

No response

Is there an existing issue for this?

  • I have searched the existing issues before opening this issue.
  • I have provided all relevant details, including the specific game and Docker images I am using if this issue is related to running a server.
  • I have checked in the Discord server and believe this is a bug with the software, and not a configuration issue with my specific system.
@itsvic-dev itsvic-dev added the not confirmed Report seems plausible but requires additional testing or 3rd part confirmation. label Mar 25, 2024
itsvic-dev added a commit to itsvic-dev/wings-public that referenced this issue Mar 25, 2024
itsvic-dev added a commit to itsvic-dev/wings-public that referenced this issue Mar 25, 2024
@matthewpi matthewpi added bug Something that's not working as it's intended to be. and removed not confirmed Report seems plausible but requires additional testing or 3rd part confirmation. labels Mar 25, 2024
@matthewpi matthewpi moved this from 🆕 New to 📋 Backlog in Backlog Mar 25, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Backlog Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that's not working as it's intended to be.
Projects
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

2 participants