Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using JWT auth Ctrl-Q will create new proxy session(s) without deleting it/them before exiting #403

Open
mountaindude opened this issue Feb 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@mountaindude
Copy link
Contributor

While this works, it means the 5-concurrent-sessions limit will be reached sooner or later.
The sessions will eventually (depending on the session timeout setting in the QMC) time out and be deleted, but that timeout is by default 30 minutes.

A better (?) approach:

  • Make a call to some QRS endpoint, just to force an authentication with the proxy service.
    • Capture the session cookie and keep track of the session ID that is stored in that cookie.
    • The cookie name is set per virtual proxy in the QMC.
  • Use the session ID when calling the Sense APIs involved in the Ctrl-Q that's to be carried out
  • Before exiting, close the session via enigma.js, as is done today.
  • Return the session ID from each of the functions that implement Ctrl-Q's various commands.
    • This will enable outside code (e.g. unit tests) to clear up sessions using the QPS, if needed.
@mountaindude mountaindude added the enhancement New feature or request label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant