Add UUID and Instance UUID in VM labels

Dockerfile

@@ -1,4 +1,4 @@
-FROM python:3.7-alpine
+FROM python:3.12-alpine
 
 LABEL MAINTAINER="Daniel Pryor <[email protected]>"
 LABEL NAME=vmware_exporter

docker-compose.yml

@@ -2,16 +2,14 @@ version: '2'
 services:
   vmware_exporter:
     # Using the latest tag, but you can use vers(v0.9.5 for example
-    image: pryorda/vmware_exporter:latest
+    image: localhost/pryorda/vmware_exporter:dev
+    build:
+      context: .
+      dockerfile: Dockerfile
     ports:
-        - "9275:9272"
-    environment:
-        VSPHERE_HOST: "vcenter-host"
-        VSPHERE_USER: "username"
-        VSPHERE_PASSWORD: "P@ssw0rd"
-        VSPHERE_IGNORE_SSL: "True"
-        VSPHERE_COLLECT_VMS: "False"
-        VSPHERE_COLLECT_VMGUESTS: "False"
+        - "9272:9272"
+    volumes:
+      - ./config.yml:/config.yml:ro
     restart: always
     #FOR DEBUG UNCOMMENT NEXT LINE
-    #command: ["-l","DEBUG"]
+    command: ["-l","DEBUG", "-c" , "/config.yml"]

requirements.txt

@@ -1,6 +1,7 @@
-prometheus-client==0.0.19
+prometheus-client==0.21.0
 pytz
 pyvmomi>=6.5
 twisted>=14.0.2
 pyyaml>=5.1
 service-identity
+requests

vmware_exporter/vmware_exporter.py

@@ -94,10 +94,10 @@ def __init__(
 
         # label names and ammount will be needed later to insert labels from custom attributes
         self._labelNames = {
-            'vms': ['vm_name', 'ds_name', 'host_name', 'dc_name', 'cluster_name'],
-            'vm_perf': ['vm_name', 'ds_name', 'host_name', 'dc_name', 'cluster_name'],
-            'vmguests': ['vm_name', 'ds_name', 'host_name', 'dc_name', 'cluster_name'],
-            'snapshots': ['vm_name', 'ds_name', 'host_name', 'dc_name', 'cluster_name'],
+            'vms': ['vm_name', 'ds_name', 'host_name', 'dc_name', 'cluster_name', 'uuid', 'instance_uuid', 'moid'],
+            'vm_perf': ['vm_name', 'ds_name', 'host_name', 'dc_name', 'cluster_name', 'uuid', 'instance_uuid', 'moid'],
+            'vmguests': ['vm_name', 'ds_name', 'host_name', 'dc_name', 'cluster_name', 'uuid', 'instance_uuid','moid'],
+            'snapshots': ['vm_name', 'ds_name', 'host_name', 'dc_name', 'cluster_name', 'uuid', 'instance_uuid','moid'],
             'datastores': ['ds_name', 'dc_name', 'ds_cluster'],
             'hosts': ['host_name', 'dc_name', 'cluster_name'],
             'host_perf': ['host_name', 'dc_name', 'cluster_name'],
@@ -738,6 +738,8 @@ def vm_inventory(self):
             'runtime.host',
             'parent',
             'summary.config.vmPathName',
+            'summary.config.uuid',
+            'summary.config.instanceUuid',
         ]
 
         if self.collect_only['vms'] is True:
@@ -1104,6 +1106,15 @@ def vm_labels(self):
             if host_moid in host_labels:
                 labels[moid] = labels[moid] + host_labels[host_moid]
 
+            if 'summary.config.uuid' in row:
+                labels[moid] += [row['summary.config.uuid']]
+            else:
+                labels[moid] += ["no_uuid"]
+            if 'summary.config.instanceUuid' in row:
+                labels[moid] += [row['summary.config.instanceUuid']]
+            else:
+                labels[moid] += ["no_instanceUuid"]
+            labels[moid] += [moid]
             """
             this code was in vm_inventory before
             but I have the feeling it is best placed here where
@@ -1188,7 +1199,7 @@ def updateMetricsLabelNames(self, metrics, metric_types):
                 for metric_name in self._metricNames.get(metric_type, []):
                     metric = metrics.get(metric_name)
                     labelnames = metric._labelnames
-                    metric._labelnames = labelnames[0:len(self._labelNames[metric_type])]
+                    metric._labelnames = list(labelnames[0:len(self._labelNames[metric_type])])
                     metric._labelnames += customAttributesLabelNames
                     metric._labelnames += labelnames[len(self._labelNames[metric_type]):]
                     metric._labelnames = list(map(lambda x: re.sub('[^a-zA-Z0-9_]', '_', x), metric._labelnames))
@@ -1939,6 +1950,8 @@ def _async_render_GET(self, request):
             logging.error(traceback.format_exc())
             request.setResponseCode(500)
             request.write(b'# Collection failed')
+            if request._disconnected:
+                return
             request.finish()
 
         # We used to call request.processingFailed to send a traceback to browser
@@ -1982,10 +1995,11 @@ def generate_latest_metrics(self, request):
         registry = CollectorRegistry()
         registry.register(ListCollector(metrics))
         output = generate_latest(registry)
-
         request.setHeader("Content-Type", "text/plain; charset=UTF-8")
         request.setResponseCode(200)
         request.write(output)
+        if request._disconnected:
+                return
         request.finish()