Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong tooltip on macos #12898

Open
1 of 2 tasks
Yornik opened this issue Jun 24, 2024 · 2 comments · May be fixed by #12899
Open
1 of 2 tasks

Wrong tooltip on macos #12898

Yornik opened this issue Jun 24, 2024 · 2 comments · May be fixed by #12899

Comments

@Yornik
Copy link

Yornik commented Jun 24, 2024

Description of the bug

image

This should say ⌘+mousewheel

Project file & How to reproduce

On mac open one of the side tools and hover over the sliders

Checklist of files included above

  • Project file
  • Screenshot

Version of PrusaSlicer

2.8.0-beta1

Operating system

macos

Printer model

prusa mk3s
@Yornik
Copy link
Author

Yornik commented Jun 24, 2024 •
edited
Loading

I see this in the code but I don't know enough c++ to exactly change this and debug:

src/slic3r/GUI/HintNotification.cpp
354:			boost::replace_all(fulltext, "Ctrl+", "⌘");

but here the code is "Ctrl +" :

src/slic3r/GUI/Gizmos/GLGizmoSeam.cpp
171:    if (m_imgui->slider_float("##clp_dist", &clp_dist, 0.f, 1.f, "%.2f", 1.0f, true, _L("Ctrl + Mouse wheel")))

@Yornik Yornik linked a pull request Jun 24, 2024 that will close this issue
Open
@Yornik
Copy link
Author

Yornik commented Jun 24, 2024

That was the wrong place i created the pr with the improved code. it is ready for reviewing

lukasmatena pushed a commit that referenced this issue Sep 12, 2024
@YuSanka @lukasmatena
Fix for #12898 - Wrong tooltip on macos
d1d9a82 
+ Fixed tooltips for layers double slider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix for tooltips in gizmos for macos Yornik/PrusaSlicer
1 participant
@Yornik