Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Autoload procedure can trigger during mintemp #2605

Closed
awenelo opened this issue Apr 14, 2020 · 5 comments · May be fixed by #2788
Closed

[BUG] Autoload procedure can trigger during mintemp #2605

awenelo opened this issue Apr 14, 2020 · 5 comments · May be fixed by #2788
Labels
bug FW 3.8.1 firmware 3.8.1 stale-issue

Comments

@awenelo
Copy link
Contributor

awenelo commented Apr 14, 2020

Printer type - MK3S
Printer firmware version- 3.8.1

Describe the bug
During a Mintemp error, if the filament sensor newly detects the presence of filament (filament sensors state goes from 0 to 1) the Autoload preheat menu will still open.

To Reproduce
Unload filament
Turn on Autoload
Unplug hotend thermistor
Insert filament
Autoload preheat menu opens

Or
Instead of unplugging the thermistor, place in an environment cold enough to trigger mintemp.

Expected behaviour
During Mintemp, a preheat menu should not open.
@awenelo awenelo added the bug label Apr 14, 2020
@leptun
Copy link
Collaborator

leptun commented Apr 14, 2020

@awenelo Thank you for reporting this. We'll take a look into the issue and fix it. Please note that this fix might not be part of 3.9.0 as we are nearing the release of it.

I'm thinking that we could disable autoload when any thermal error occurs. Since the user can't realistically do anything with the printer once the error is triggered, this shouldn't cause us problems since we never have to enable it again until reboot.

@awenelo
Copy link
Contributor Author

awenelo commented Apr 15, 2020

@leptun I've gotten a working fix for it. Should I do a pull request?

@leptun
Copy link
Collaborator

leptun commented Apr 16, 2020

Yes.

@awenelo awenelo mentioned this issue Apr 16, 2020
Closed
@JohnnyDeer JohnnyDeer added the FW 3.8.1 firmware 3.8.1 label May 13, 2020
@awenelo awenelo mentioned this issue Aug 2, 2020
Open
@github-actions
Copy link

This issue has been flagged as stale because it has been open for 60 days with no activity. The issue will be closed in 7 days unless someone removes the "stale" label or adds a comment.

@github-actions
Copy link

This issue has been closed due to lack of recent activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug FW 3.8.1 firmware 3.8.1 stale-issue
Projects
None yet
Milestone
No milestone
3 participants
@leptun @JohnnyDeer @awenelo