-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ESP32-WROVER board #22
Comments
Great. I need to order an ESP32-Wroover, test its stability, and then optimize the code to be more user-friendly and usable. |
Hello @firstmustburn support for the ESP32-WROVER is already added. Can you tested it please ? |
It will probably be a week or so before I will have access to the hardware to test, but I will check it out and post back. |
@firstmustburn Sure. Thank you. I tested FW on the board ESP32-WROVER, and everything works for me. |
Hello @johnyHV, I tested the current master branch and it worked fine. I made some detailed note below. I think the big suggestions are:
Install libraris:
cd path/to/Prusa-Firmware-ESP32-Cam/ESP32_PrusaConnectCam
mkdir libraries
git clone [email protected]:mathieucarbou/AsyncTCP.git --branch v3.1.4 --single-branch
git clone [email protected]:mathieucarbou/ESPAsyncWebServer.git --branch v3.0.6 --single-branch
git clone [email protected]:bblanchon/ArduinoJson.git --branch v7.1.0 --single-branch
git clone [email protected]:ricaun/ArduinoUniqueID.git --branch 1.3.0 --single-branch
git clone [email protected]:RobTillaart/DHTNew.git --branch 0.4.20 --single-branch Set the Arduino options as described at:
Run Got this error once, re-ran it and it compiled without errors
After programming, the board was intermittenly resetting. Connecting the serial monitor in the arduino IDE, the log ended with:
Found this instruction in the readme, consider making it bigger!
Modified the mcu_cfg.h to set: #define AI_THINKER_ESP32_CAM false
#define ESP32_WROVER_DEV true
#define CAMERA_MODEL_ESP32_S3_DEV_CAM false
#define CAMERA_MODEL_ESP32_S3_EYE_2_2 false
#define CAMERA_MODEL_XIAO_ESP32_S3_CAM false
#define CAMERA_MODEL_ESP32_S3_CAM false Rebuilt and reflashed, everything booted fine. Connected to the AP and configured the WIFI. Put the old device token in, and was getting 400 and 403 errors. Deleted the camera in prusa-connect, created a new camera, and everything worked fine. |
@johnyHV One more thing: is there any plan to set up CI to build the firmware binaries so they can just be downloaded? If you want help containerizing the build, I could work on that. |
@firstmustburn I understand what you are focusing on and what your goal is. However, the primary purpose is not for the user to compile the source code themselves. The user should download the precompiled binary from the release. Compiling their own source code is only intended for experienced users. I don't want to unnecessarily complicate the guide with instructions for installing libraries and compiling. It could make the README confusing. Nevertheless, I will incorporate some of your ideas into the README and try to improve it. Each board has its specific settings in the Arduino IDE. Therefore, a separate guide is created for each board. Thank you, I plan to create a pipeline (i have skill only with bitbucket pipeline, but it's ist very similar). That's why I have created the compilation scripts. Unfortunately, I haven't gotten around to it yet. However, I think for the pipelines on GitHub its neccesary pay extra money. I'm happy the new firmware is working. |
I create pull request #21.
This adds support for the Freenove ESP32-WROVER board. Everything in the original firmware works fine except that the GPIO must be remapped. So there are #if statements to make this change in two files. I also wrote a detailed readme for building and installing the code on the board.
The main goal here is to have the ESP32-WROVER benefit from bug fixes and improvements. Putting #if switch statements around the GPIO definitions doesn't seem that elegant or scalable, but I could not find a better strategy anywhere. Also, it seems like the Arduino IDE doesn't have a way to add compiler flags, so the #define for the flag has to be set in each file. If there's a different, preferred way of doing this, I'm happy to rework the code and update the PR.
The text was updated successfully, but these errors were encountered: