Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serde(flatten) attribute introduces floats #132

Closed
4 tasks done
kwtalley opened this issue Nov 16, 2023 · 3 comments
Closed
4 tasks done

serde(flatten) attribute introduces floats #132

kwtalley opened this issue Nov 16, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@kwtalley
Copy link
Collaborator

kwtalley commented Nov 16, 2023

Summary of Bug

When using serde(flatten) to fix the missing fields in some metadata types (since they use protobuf Oneof), the generated/compiled code introduces floats which will cause the wasm store function to fail. This issue serves to track the progress of the cosmwasm serde-json-wasm issue #43

Version

provwasm 2.0.0+


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@kwtalley kwtalley added the bug Something isn't working label Nov 16, 2023
@kwtalley kwtalley self-assigned this Nov 16, 2023
@kwtalley
Copy link
Collaborator Author

Looks like Float support has been added to cosmwasm 1.5, but we need to wait until provenance uses wasmd 0.44, which will require cosmos-sdk 0.47+

@kwtalley kwtalley moved this from Todo to Backlog in Provenance Core Protocol Team Mar 7, 2024
@kwtalley
Copy link
Collaborator Author

kwtalley commented Mar 8, 2024

this will be handled with #141

@kwtalley
Copy link
Collaborator Author

Resolved with #160 and serde no longer used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

1 participant