From 08a1a0a204582c00fd16ffae5dfc7a7d22ee9b9a Mon Sep 17 00:00:00 2001 From: Carlton Hanna Date: Thu, 23 May 2024 10:41:58 -0600 Subject: [PATCH 1/2] `add-net-asset-values` command now correctly uses the from `flag`'s `AccAddress` (#1996) * Add from address and not from value from cmd * add change log entry * remove trailing spaces --- x/marker/client/cli/tx.go | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/x/marker/client/cli/tx.go b/x/marker/client/cli/tx.go index 28f6a8eed9..d0ef521640 100644 --- a/x/marker/client/cli/tx.go +++ b/x/marker/client/cli/tx.go @@ -1069,12 +1069,7 @@ func GetCmdAddNetAssetValues() *cobra.Command { return err } - msg := types.NewMsgAddNetAssetValuesRequest(denom, clientCtx.From, netAssetValues) - if err := msg.ValidateBasic(); err != nil { - return err - } - - return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), msg) + return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), types.NewMsgAddNetAssetValuesRequest(denom, clientCtx.GetFromAddress().String(), netAssetValues)) }, } flags.AddTxFlagsToCmd(cmd) From b6800781af339ba2da6ce9b6e9fa97a5e126fb0a Mon Sep 17 00:00:00 2001 From: Carlton N Hanna Date: Thu, 23 May 2024 11:59:54 -0600 Subject: [PATCH 2/2] add changelog entry --- CHANGELOG.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b414f33b5c..baff0c369b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -37,7 +37,9 @@ Ref: https://keepachangelog.com/en/1.0.0/ ## [Unreleased] -* nothing +### Bug Fixes + +* The `add-net-asset-values` command now correctly uses the from `flag`'s `AccAddress` [#1995](https://github.com/provenance-io/provenance/issues/1995). ---