You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Determine if the net asset value needs to be written as a record when adding a marker, based on whether it was explicitly set by the user.
Problem Definition
Currently, the net asset value is being written on an add marker transaction even if it hasn't been set by the user. This can cause confusion as it is unclear whether the value was intentionally left unset by the user or if they are using an older proto version that does not include these fields.
Proposal
Implement a mechanism to check if the volume and usd_mills fields have been explicitly set by the user before writing them as a record in the add marker transaction. This could involve:
Checking for default values and determining if the fields are explicitly set.
Using wrapper types to better handle the presence or absence of these fields.
Adding version checks or flags to differentiate between different proto versions.
This enhancement will help prevent confusion and ensure that only intended values are recorded.
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged
Contributor assigned/self-assigned
The text was updated successfully, but these errors were encountered:
* add expanded nav documentation for scope
* changelog
* add volume to metadata nav protos
* add volume parameter to metadata nav
* add another changelog for nav example
* Record net value asset only when explicitly set
by user when adding marker #2030
* fix metadata nav test argument format
* lint
* ensure metadata nav uses volume of 1
special handling of unset volume in nav to be one but allow zero for backwards compatibility
* fix nav event volume
* metadata scope set nav event documentation
---------
Co-authored-by: Carlton Hanna <[email protected]>
Summary
Determine if the net asset value needs to be written as a record when adding a marker, based on whether it was explicitly set by the user.
Problem Definition
Currently, the net asset value is being written on an add marker transaction even if it hasn't been set by the user. This can cause confusion as it is unclear whether the value was intentionally left unset by the user or if they are using an older proto version that does not include these fields.
Proposal
Implement a mechanism to check if the
volume
andusd_mills
fields have been explicitly set by the user before writing them as a record in the add marker transaction. This could involve:This enhancement will help prevent confusion and ensure that only intended values are recorded.
For Admin Use
The text was updated successfully, but these errors were encountered: