Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding style guide #1690

Open
4 tasks
Taztingo opened this issue Sep 25, 2023 · 1 comment
Open
4 tasks

Coding style guide #1690

Taztingo opened this issue Sep 25, 2023 · 1 comment
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@Taztingo
Copy link
Contributor

Summary

The Provenance code base does not have any type of coding style guide. A style guide will help team members write more uniform code and assist those that are externally contributing. This will allow us to more easily find flaws in the design of the code and bugs within the logic.

This is not something that can quickly be resolved and may need to be broken down into multiple issues and PRs.

Problem Definition

As the Provenance codebase becomes larger it will be harder to understand, debug, and contribute to.

Proposal

  1. Investigate other major golang projects and see if we can find and use a pre-existing style guide template.
  2. Create a PR for the template so the team can comment on the layout and agree upon the sections
  3. Create a PR for each section so each team member can contribute to a specific section without being overwhelmed by other sections. This will also allow us to complete simple sections without being blocked by more complex sections.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@Taztingo Taztingo added the documentation Improvements or additions to documentation label Sep 25, 2023
@Taztingo Taztingo added this to the v1.18.0 milestone Sep 25, 2023
@Taztingo
Copy link
Contributor Author

Some good resources on this are 100 Go Mistakes and some of the more popular golang projects.

Might be also helpful to reduce the amount of code we have by simplifying protocol entry points. More complex ideas can be built on top as long we provide the fundamental set of building blocks.

@iramiller iramiller modified the milestones: v1.18.0, v1.19.0 Jan 4, 2024
@SpicyLemon SpicyLemon modified the milestones: v1.19.0, v1.20.0 Jul 15, 2024
@iramiller iramiller modified the milestones: v1.20.0, backlog Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Development

No branches or pull requests

3 participants