Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mar/drandexample #280

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Mar/drandexample #280

wants to merge 14 commits into from

Conversation

mrodriguez3313
Copy link
Contributor

@mrodriguez3313 mrodriguez3313 commented Sep 23, 2022

Added a new shortcode for code blocks, I dont know if it is necessary, but its pretty cool. I did this just so I can add the drand example right into the curriculum instead of linking awkwardly to a personal repo or making the drand page much bigger. Let me know if this is a good way to go about adding a new short tutorial/example or we can scrap it and do it a different way.

@walkerlj0
Copy link
Contributor

Make this it's own tutorial section complete with Dependencies & how to set up & run the example

@walkerlj0 walkerlj0 mentioned this pull request Sep 27, 2022
@mrodriguez3313
Copy link
Contributor Author

mrodriguez3313 commented Oct 2, 2022

Please ignore the changes to script-footer.html. I was working on that page, but my code editor does "formatting on save", so it looks like I edited a lot of lines.

@mrodriguez3313 mrodriguez3313 self-assigned this Oct 5, 2022
@mrodriguez3313
Copy link
Contributor Author

mrodriguez3313 commented Oct 11, 2022

@enoldev In "drand(tutorial).md" I reference code in my personal repo. When this PR gets approved we also have to move the code into our launchpad-tutorials repo. From there I can change the script reference tags to use the official launchpad-tutorial repo.

Copy link
Contributor

@enoldev enoldev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR contains changes to other files (CSS and HTML), I think it's probably because your IDE is modifying the files automatically

content/en/curriculum/filecoin/drand(tutorial).md Outdated Show resolved Hide resolved
content/en/curriculum/filecoin/drand(tutorial).md Outdated Show resolved Hide resolved

To be able start talking with the Drand network you will need to import the necessary libraries.

<script src="https://emgithub.com/embed-v2.js?target=https%3A%2F%2Fgithub.com%2Fmrodriguez3313%2Fdrandexample%2Fblob%2Fmain%2Fbias.js%23L1-L12&style=github-dark-dimmed&type=code&showBorder=on&showLineNumbers=on&showFileMeta=on&showFullPath=on&showCopy=on"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are you supposed to do with this script? You have already run the bias.js file in the pre-requisites, are you just explaining the code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I am just explaining the code. I didn't know how else to go about it. This is my first tutorial so this would be a good discussion for me.

@mrodriguez3313
Copy link
Contributor Author

The PR contains changes to other files (CSS and HTML), I think it's probably because your IDE is modifying the files automatically

What happened was I had to get rid of the css classes I made, and so when I saved in that file. It formatted the file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants