Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor classes Component and Package to have a shared base class #608

Open
simu opened this issue Aug 25, 2022 · 0 comments
Open

Refactor classes Component and Package to have a shared base class #608

simu opened this issue Aug 25, 2022 · 0 comments
Labels
change PR with a minor change which affects users

Comments

@simu
Copy link
Member

simu commented Aug 25, 2022

Context

The current implementation uses standalone classes for managing components and packages, but the two implementations share a bunch of code, see e.g. #602 or #607. We really should refactor the two classes to have a shared base class which implements the generic functions which are identical for both dependency types.

Look at ComponentTemplater, PackageTemplater and their base class Templater for inspiration.

Alternatives

Keep code base as it currently is, accepting that we duplicate some identical code between classes Component and Package.

@simu simu added the change PR with a minor change which affects users label Aug 25, 2022
@simu simu mentioned this issue Aug 25, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change PR with a minor change which affects users
Projects
None yet
Development

No branches or pull requests

1 participant