Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4807] Masu trino query readonly user #5067

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

cgoodfred
Copy link
Contributor

@cgoodfred cgoodfred commented Apr 25, 2024

Jira Ticket

COST-4807

Description

This change will change the trino query user to a readonly user.

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Load data
  4. Run a masu trino query and see it get results back.

Release Notes

  • proposed release note
* [COST-4807](https://issues.redhat.com/browse/COST-4807) Masu trino query user is now a readonly user

@cgoodfred cgoodfred added the smoke-tests pr_check will build the image and run minimal required smokes label Apr 25, 2024
@cgoodfred cgoodfred self-assigned this Apr 25, 2024
@cgoodfred cgoodfred requested review from a team as code owners April 25, 2024 14:15
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (506059a) to head (7aba989).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5067   +/-   ##
=====================================
  Coverage   94.1%   94.1%           
=====================================
  Files        377     377           
  Lines      31346   31346           
  Branches    3715    3715           
=====================================
+ Hits       29510   29511    +1     
  Misses      1169    1169           
+ Partials     667     666    -1     

Copy link
Contributor

@djnakabaale djnakabaale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏾

@cgoodfred cgoodfred merged commit 863395f into main Apr 29, 2024
11 checks passed
@cgoodfred cgoodfred deleted the COST-4807-masu-readonly branch April 29, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants