Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4973] - Fix mid month finalization #5060

Merged
merged 3 commits into from
Apr 24, 2024
Merged

[COST-4973] - Fix mid month finalization #5060

merged 3 commits into from
Apr 24, 2024

Conversation

lcouzens
Copy link
Contributor

Jira Ticket

COST-4973

Description

This change will add an additional check to prevent us from potentially running full month reprocessing/finalisation on current months. This also prevents us from deleting ALL parquet files by mistake.

Testing

  1. Checkout Branch
  2. Restart Koku with multiple workers ideally
  3. Add AWS source
  4. Run initial ingest!
  5. Generate some new nise data (This needs to be split files, --file-row-limit)
  6. Hit download
  7. Verify only 5 days of parquet files are deleted and recreated

Feel free to compare to main, same steps as above but all parquet files outside the processing range will get cleared by mistake.

Release Notes

  • Correctly handle AWS end of Tax year billing reports
* [COST-4973](https://issues.redhat.com/browse/COST-4973) Correctly handle AWS end of Tax year billing reports

@lcouzens lcouzens added the smoke-tests pr_check will build the image and run minimal required smokes label Apr 23, 2024
@lcouzens lcouzens requested review from a team as code owners April 23, 2024 13:25
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Merging #5060 (65d07bd) into main (7fb758c) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5060   +/-   ##
=====================================
  Coverage   94.1%   94.1%           
=====================================
  Files        377     377           
  Lines      31331   31331           
  Branches    3714    3714           
=====================================
+ Hits       29492   29493    +1     
  Misses      1172    1172           
+ Partials     667     666    -1     

@lcouzens lcouzens merged commit b43681b into main Apr 24, 2024
11 checks passed
@lcouzens lcouzens deleted the COST-4973 branch April 24, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants