-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-4759] Add all_labels to back populate for ocp on cloud. #5001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myersCody
added
the
smoke-tests
pr_check will build the image and run minimal required smokes
label
Mar 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5001 +/- ##
=====================================
Coverage 94.1% 94.1%
=====================================
Files 377 377
Lines 31331 31331
Branches 3714 3714
=====================================
+ Hits 29492 29493 +1
Misses 1172 1172
+ Partials 667 666 -1 |
/retest |
bacciotti
approved these changes
Mar 27, 2024
/retest |
This likely needs a small smoke test tweak regarding resummary calls via masu. @esebesto is looking into it for us. 🙇 |
/retest |
1 similar comment
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-4759
Description
This change will add all_labels to the back populate pieces of our ocp on cloud infrastructure.
Testing
Release Notes