Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4759] Add all_labels to back populate for ocp on cloud. #5001

Merged
merged 9 commits into from
Apr 26, 2024

Conversation

myersCody
Copy link
Contributor

@myersCody myersCody commented Mar 26, 2024

Jira Ticket

COST-4759

Description

This change will add all_labels to the back populate pieces of our ocp on cloud infrastructure.

Testing

SELECT usage_start, all_labels->>'your_key_here' as tag, sum(infrastructure_raw_cost) as infra_cost FROM reporting_ocpusagelineitem_daily_summary WHERE all_labels ? 'your_key_here' and usage_start >= '2024-03-01' and usage_start <= '2024-04-01' group by usage_start ORDER BY usage_start;

Release Notes

  • proposed release note
* [COST-4759](https://issues.redhat.com/browse/COST-4759) Bug fix for all labels for ocp on cloud

@myersCody myersCody added the smoke-tests pr_check will build the image and run minimal required smokes label Mar 26, 2024
@myersCody myersCody requested review from a team as code owners March 26, 2024 16:57
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (ffae50c) to head (6df5ee2).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5001   +/-   ##
=====================================
  Coverage   94.1%   94.1%           
=====================================
  Files        377     377           
  Lines      31331   31331           
  Branches    3714    3714           
=====================================
+ Hits       29492   29493    +1     
  Misses      1172    1172           
+ Partials     667     666    -1     

@myersCody
Copy link
Contributor Author

/retest

@djnakabaale
Copy link
Contributor

/retest

@lcouzens
Copy link
Contributor

This likely needs a small smoke test tweak regarding resummary calls via masu. @esebesto is looking into it for us. 🙇

@lcouzens
Copy link
Contributor

/retest

1 similar comment
@lcouzens
Copy link
Contributor

/retest

@lcouzens lcouzens enabled auto-merge (squash) April 26, 2024 13:05
@lcouzens lcouzens merged commit 45683f9 into main Apr 26, 2024
11 checks passed
@lcouzens lcouzens deleted the cost-4759-zero-infrastructure-cost-for-tags branch April 26, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants