-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update trino and hive images for local dev #4717
Conversation
maskarb
commented
Oct 4, 2023
•
edited
Loading
edited
- update trino ARM images
- update trino configuration
- move trino/hadoop configs into dev/containers and update volume mounts
I tried ingesting a source locally with this branch and ran into this issue:
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the hadoop config is used by the trino container, it should go in /dev/containers/trino/etc
. Then you may be able to bind mount dev/containers/trino/etc/:/etc/trino/
and not each file individually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can move the hadoop file, but they all need to be mounted individually because /etc/trino
contains files that are wiped out if mounted this way. Is there a way to merge the files in the container with the files from the volume mount?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bind mount would replace /etc/trino
in the container. There is no way to merge the contents.
We are mounting a little less than half of the config files. We could copy the remaining config files to the container host to make the bind mount simpler.
/etc/trino/
├── catalog
│ ├── blackhole.properties
│ ├── config.yaml
│ ├── hive.properties # current bind mount
│ ├── jmx.properties
│ ├── memory.properties
│ ├── tpcds.properties
│ └── tpch.properties
├── config.properties # current bind mount
├── hadoop-config
│ └── core-site.xml # current bind mount
├── jvm.config # current bind mount
├── log.properties # current bind mount
└── node.properties