Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update trino and hive images for local dev #4717

Merged
merged 15 commits into from
Apr 23, 2024
Merged

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Oct 4, 2023

  • update trino ARM images
  • update trino configuration
  • move trino/hadoop configs into dev/containers and update volume mounts

@maskarb maskarb requested review from a team as code owners October 4, 2023 16:32
samdoran
samdoran previously approved these changes Oct 4, 2023
@myersCody
Copy link
Contributor

I tried ingesting a source locally with this branch and ran into this issue:

koku-koku-worker-1  |     raise self._process_error(response["error"], response.get("id"))
koku-koku-worker-1  | trino.exceptions.TrinoUserError: TrinoUserError(type=USER_ERROR, name=NOT_SUPPORTED, message="Unsupported Trino column type (varchar) for Parquet column ([node_role] optional int32 node_role)", query_id=20231010_195704_00060_5giaz)
koku-koku-worker-1  | [2023-10-10 19:57:04,859] ERROR 28fb8e2d-d833-4c72-94a2-7da5c8e3c963 62 Task failed: TrinoUserError(type=USER_ERROR, name=NOT_SUPPORTED, message="Unsupported Trino column type (varchar) for Parquet column ([node_role] optional int32 node_role)", query_id=20231010_195704_00060_5giaz)

@maskarb maskarb marked this pull request as draft October 27, 2023 14:48
Copy link

sonarcloud bot commented Nov 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@maskarb maskarb marked this pull request as ready for review April 16, 2024 16:51
@maskarb maskarb changed the title update trino and hive ARM images for local dev update trino and hive images for local dev Apr 16, 2024
myersCody
myersCody previously approved these changes Apr 16, 2024
Copy link
Contributor

@samdoran samdoran Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the hadoop config is used by the trino container, it should go in /dev/containers/trino/etc. Then you may be able to bind mount dev/containers/trino/etc/:/etc/trino/ and not each file individually.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can move the hadoop file, but they all need to be mounted individually because /etc/trino contains files that are wiped out if mounted this way. Is there a way to merge the files in the container with the files from the volume mount?

Copy link
Contributor

@samdoran samdoran Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bind mount would replace /etc/trino in the container. There is no way to merge the contents.

We are mounting a little less than half of the config files. We could copy the remaining config files to the container host to make the bind mount simpler.

/etc/trino/
├── catalog
│   ├── blackhole.properties
│   ├── config.yaml
│   ├── hive.properties  # current bind mount
│   ├── jmx.properties
│   ├── memory.properties
│   ├── tpcds.properties
│   └── tpch.properties
├── config.properties  # current bind mount
├── hadoop-config
│   └── core-site.xml  # current bind mount
├── jvm.config # current bind mount
├── log.properties  # current bind mount
└── node.properties

@maskarb maskarb merged commit cd2db57 into main Apr 23, 2024
11 checks passed
@maskarb maskarb deleted the update-hive-trino-arm branch April 23, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants