Replace with constants.

project-koku · Apr 29, 2024 · 0576694 · 0576694
1 parent c4eeb42
commit 0576694
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/koku/cost_models/serializers.py b/koku/cost_models/serializers.py
@@ -66,7 +66,7 @@ class DistributionSerializer(BaseSerializer):
 
     def validate(self, data):
         """Run validation for distribution options."""
-        default_to_true = ["platform_cost", "worker_cost"]
+        default_to_true = [metric_constants.PLATFORM_COST, metric_constants.WORKER_UNALLOCATED]
         distribution_keys = metric_constants.DEFAULT_DISTRIBUTION_INFO.keys()
         diff = set(distribution_keys).difference(data)
         if diff == distribution_keys:

diff --git a/koku/cost_models/test/test_serializers.py b/koku/cost_models/test/test_serializers.py
@@ -847,8 +847,8 @@ def test_valid_distribution_info_keys(self):
                 instance = serializer.save()
             self.assertIsNotNone(instance)
             # Add in default options
-            valid_distrib_obj["network_unattributed"] = False
-            valid_distrib_obj["storage_unattributed"] = False
+            valid_distrib_obj[metric_constants.NETWORK_UNATTRIBUTED] = False
+            valid_distrib_obj[metric_constants.STORAGE_UNATTRIBUTED] = False
             self.assertEqual(instance.distribution_info, valid_distrib_obj)
 
     def test_invalid_distribution_info_keys(self):