Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check package for dependencies expiring soon. #62

Open
ohagen opened this issue Oct 31, 2022 · 3 comments
Open

Check package for dependencies expiring soon. #62

ohagen opened this issue Oct 31, 2022 · 3 comments

Comments

@ohagen
Copy link
Member

ohagen commented Oct 31, 2022

Check gen3sis

rgdal and rgeos will be retired by end of 2023. Gen3sis imports raster and sp.

Package sp currently suggests both rgeos and rgdal. It uses rgdal for the validation of CRS objects (proj4string or WKT descriptions of coordinate reference systems), and it uses rgeos to sort out which rings are holes when a SpatialPolygons object does not have a flag indicating this. This only happens for saved objects that are at least 10 years old. Both functionalities (CRS validation, hole detection) can however easily be substituted by functions in package sf.

Package “sp” is modified such that it no longer depends on “rgdal” or “rgeos” - Branch evolution of Roger Bivand’s fork of sp, which can be installed with

devtools::install_github("rsbivand/sp@evolution")

contains conditional code that prevents sp to call code in rgdal or rgeos. This can be enabled by setting

Sys.setenv("SP_EVOLUTION_STATUS"=2)

after that, e.g. a call to CRS("+proj=longlat") calls sf::st_crs() to validate the coordinate reference system and retrieve the WKT representation.

@isaacovercast
Copy link

isaacovercast commented Jan 3, 2023

Probably related, a clean install of R 4.2.2 and install.packages("gen3sis") errors out on dependencies:

image

I installed raster (3.5_21) using conda and then tried the gen3sis install again and it worked. conda install -c conda-forge r-raster.

@benj919
Copy link
Collaborator

benj919 commented Nov 30, 2023

Raster moved on to rely on terra and will stay in basic maintenance for the moment: rspatial/raster#325 . Gen3sis and it's dependencies should be installable (tested with R4.3.2 on Ubuntu)
I think that means gDistance will remain on raster for the immediate future. I suggest we follow gDistance here as it's our critical external dependency...

@isaacovercast sorry for the long silence. Iirc the was a transition period where not all dependencies where in sync on what packages they relied on from this whole story. That resolved itself eventually.

@ohagen I suggest we leave this ticket open as a reminder to check on gDistance from time to time

@ohagen
Copy link
Member Author

ohagen commented Nov 30, 2023

@benj919 Thanks Benji, I like the idea... otherwise we just forget!

@isaacovercast Sorry for the silence too, somehow I did not see this here... I guess all working. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants