Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu height should have a minimum value of 5 lines #1

Open
Acpear opened this issue Nov 12, 2024 · 0 comments
Open

Menu height should have a minimum value of 5 lines #1

Acpear opened this issue Nov 12, 2024 · 0 comments

Comments

@Acpear
Copy link

Acpear commented Nov 12, 2024

Firstly, congratulations on this great project! Thanks for your efforts in broadening the reach and usage of HackerNews / YCombinator!

I've noticed an issue with the terminal menu when the terminal height is too small. The menu, which consists of one line for "option", three lines for "summary", "open", and "close", plus one bottom line, scales according to a ratio of terminal height. However, when the terminal height becomes too small, the menu's content becomes incomplete even invisible as it doesn’t have enough lines to display all its elements.

To ensure the menu remains readable, I suggest setting a minimum height of 5 lines. This way, all the content will always be visible, regardless of the terminal height. Below are some screenshots showing how the menu height changes along with terminal height.

normal case

Screenshot_20241112_164126

edge of normal and abnormal

Screenshot_20241112_164151

2 lines of options

Screenshot_20241112_164212

1 lines of options

Screenshot_20241112_164244

options are invisible

Screenshot_20241112_164300

It would be a good news and I would appreciate it if you can make a small fix on that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant