Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] version-comparator: do not remotely load B.2.0 #8

Open
tbouffard opened this issue Aug 16, 2022 · 0 comments
Open

[FEAT] version-comparator: do not remotely load B.2.0 #8

tbouffard opened this issue Aug 16, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@tbouffard
Copy link
Member

tbouffard commented Aug 16, 2022

Is your feature request related to a problem? Please describe.
Currently, the content of the B.2.0 file is retrieved by the page. While it ensures that we always use the latest version of the file, it has several drawbacks

  • prevent to run the tool offline
  • extra http query: there is no browser cache once the browser is closed by the script. So, we are redoing the query over and over
  • the file doesn't change or very rarely, so there is no need to ensure it is up-to-date. In addition, if updated occurs, the tool is not aware of it and it may create discrepancies

Describe the solution you'd like
Store the content of the file in the repository

Additional context
In the examples repository, we are storing the content in a JS function. We can replicate this here or store it in a constant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant