Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[contribution] make test #991

Open
MarieS-WiMLDS opened this issue Dec 19, 2024 · 7 comments · May be fixed by #993
Open

[contribution] make test #991

MarieS-WiMLDS opened this issue Dec 19, 2024 · 7 comments · May be fixed by #993
Labels
chore Internal enhancement work to be done

Comments

@MarieS-WiMLDS
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I'd like to be able to run the tests very easily and quickly, without knowing what's behind, pytest or anything else.

Describe the solution you'd like

make test

Describe alternatives you've considered, if relevant

No response

Additional context

No response

@MarieS-WiMLDS MarieS-WiMLDS added enhancement New feature or request needs-triage This has been recently submitted and needs attention chore Internal enhancement work to be done and removed enhancement New feature or request needs-triage This has been recently submitted and needs attention labels Dec 19, 2024
@thomass-dev
Copy link
Collaborator

thomass-dev commented Dec 20, 2024

@augustebaum i remember you had a target in your local Makefile to do this?

I'd like to be able to run the tests very easily and quickly [...].

@MarieS-WiMLDS by quickly you mean in one command?

@MarieS-WiMLDS
Copy link
Contributor Author

yes, I meant quickly accessible.

@rouk1 rouk1 linked a pull request Dec 20, 2024 that will close this issue
@glemaitre
Copy link
Member

Just a thought regarding Makefile: it does not work on Windows.

Some alternatives to know about:

  • spin: https://github.com/scientific-python/spin. The idea is to provide consistent developer commands across the scientific ecosystem that works and all platforms. It is used in NumPy, SciPy, scikit-learn as examples
  • pixi: https://pixi.sh/latest/. This is more generic tools. In addition to manage environment for instance for the CI, it provides a way to define tasks that is exactly what you need here. We give it a "spin" in skrub.

Usage as a user

spin tests
pixi run tests

I don't think it is a priority right now but it could be great to evaluate those solutions. Feel free to open a specific issues particularly for this feature.

@thomass-dev
Copy link
Collaborator

The makefile is only for contributors use.

@glemaitre
Copy link
Member

The makefile is only for contributors use.

Contributors can still have Windows :). The tools mentioned are really crafted for contributors/developers tool not end-user.

@augustebaum
Copy link
Contributor

augustebaum commented Dec 20, 2024

That's an issue for our docs as well, since we build them using sphinx's make html. Maybe we could just use sphinx-build directly, like they explain in the docs

@thomass-dev
Copy link
Collaborator

thomass-dev commented Dec 20, 2024

For now, we all use unix-like OS compatible with Makefile and we don't have external contributors.
IMO, keep moving, and come back to your suggestion when we have to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Internal enhancement work to be done
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants