Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide release artifacts in a public Maven repository #159

Open
nicow-odit opened this issue Aug 29, 2023 · 5 comments
Open

Provide release artifacts in a public Maven repository #159

nicow-odit opened this issue Aug 29, 2023 · 5 comments

Comments

@nicow-odit
Copy link

Please publish the release artifacts to a public Maven repository, e.g. Maven Central, so that they can be easily consumed by Maven, Gradle, etc.

This is especially important due to the fact that tools like https://jitpack.io/ fail to circumvent this since there's a build dependency on the client (see https://jitpack.io/com/github/privacyidea/keycloak-provider/v1.1.0/build.log).

@nilsbehlen
Copy link
Member

What are you doing with it that you would need it on mavencentral? If there is a good reason for it, we might consider it, but otherwise its just additional work.

@nicow-odit
Copy link
Author

We're building a customized Keycloak Docker image consisting of several providers. This is done using Maven. The idea is to pull PrivacyIDEA's keycloak-provider using Maven's standard mechanisms as we do for other providers, unpack, customize some templates, re-package, and include it in the built Docker image.

@belfhi
Copy link

belfhi commented Sep 1, 2023

Out of curiosity @nicow-odit , how do you use maven during the docker build? I just curl all my providers... 😬

@nicow-odit
Copy link
Author

It's the other way around: the Docker build is embedded in the Maven build. During the latter we build providers as sub-modules first that will be shipped in the final Docker image later. One of the sub-modules would be PrivacyIDEA's keycloak provider that also needs some customization. This is why it's not sufficient to just pull it in, but to define it as a (Maven) dependency to be able to compile and build against it.

@nilsbehlen
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants