From 7569666ef61b3b8c421db2f4d98db0f3344aa7fb Mon Sep 17 00:00:00 2001 From: Ivar Derksen Date: Fri, 8 Nov 2024 13:18:04 +0000 Subject: [PATCH] CI/CD: make gcloud project name configurable using secret --- .github/workflows/README.md | 1 + .github/workflows/status-checks.yml | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/README.md b/.github/workflows/README.md index abd03019..fa5f34a9 100644 --- a/.github/workflows/README.md +++ b/.github/workflows/README.md @@ -17,6 +17,7 @@ This means you need to upload every secret twice. - `APPLE_DEVELOPMENT_CERTIFICATE`: Base64 encoded PKCS12 certificate of the Apple development certificate, check the [Fastlane docs](../../fastlane/README.md#generating-new-certificates) for generating instructions. This certificate expires every year and is linked to the 'IRMA Beheer' email address. - `APPLE_DEVELOPMENT_CERTIFICATE_PASSWORD`: password of the Apple development certificate (see above). - `APPLE_DEVELOPMENT_PROVISIONING_PROFILE`: Base64 encoded Apple provisioning profile that is linked to the development certificate (see above). This should be renewed when the development certificate is being renewed. +- `GCLOUD_PROJECT_NAME`: Google Firebase project name (for Device Test Lab access). - `GCLOUD_SERVICE_KEY`: Google Firebase service account JSON key (for Device Test Lab access). ## Delivery diff --git a/.github/workflows/status-checks.yml b/.github/workflows/status-checks.yml index 6dbb3e7a..c2149b01 100644 --- a/.github/workflows/status-checks.yml +++ b/.github/workflows/status-checks.yml @@ -224,7 +224,7 @@ jobs: run: gcloud auth activate-service-account --key-file <(echo $GCLOUD_SERVICE_KEY) shell: bash - name: Set Firebase project - run: gcloud config set project yivimobile + run: gcloud config set project ${{ secrets.GCLOUD_PROJECT_NAME }} - name: Run integration tests run: gcloud firebase test ios run --test ios_tests.zip --timeout 20m --device=model=iphone8,orientation=portrait --device=model=iphone8,orientation=landscape integration-test-android: @@ -246,6 +246,6 @@ jobs: run: gcloud auth activate-service-account --key-file <(echo $GCLOUD_SERVICE_KEY) shell: bash - name: Set Firebase project - run: gcloud config set project yivimobile + run: gcloud config set project ${{ secrets.GCLOUD_PROJECT_NAME }} - name: Run integration tests run: gcloud firebase test android run --use-orchestrator --app app-alpha-debug.apk --test app-alpha-debug-androidTest.apk --timeout 20m --device=model=Pixel2,version=28,orientation=portrait --device=model=Pixel2,version=28,orientation=landscape