Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot rename slices without breaking slice machine - V 1.5.0 #1037

Open
Ali-Parandeh opened this issue Jul 7, 2023 · 2 comments
Open

Cannot rename slices without breaking slice machine - V 1.5.0 #1037

Ali-Parandeh opened this issue Jul 7, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@Ali-Parandeh
Copy link

Ali-Parandeh commented Jul 7, 2023

Versions

  • slice-machine-ui: 1.5.0
  • node: V 16.18.0

Steps to reproduce

Create a slice.
Save slice
Push Slice
Rename Slice
Save Slice
Push Slice
Create a new slice with old slice name
Save Slice
Push Slice

You will face issues.

What is expected?

You should be able to rename old slices, save them and push them. Then create new slices with old names.
For instance, I created a Services slice then realised I needed to call it ServicesCategory slice. And wanted to create another slice called Services but couldn't.

What is actually happening?

  1. Duplicate Slices
Screenshot 2023-07-07 at 18 14 19 Screenshot 2023-07-07 at 18 18 07 Screenshot 2023-07-07 at 18 14 03 Screenshot 2023-07-07 at 18 14 52
  1. When trying to edit one of the slices - Remove a field then save.
Screenshot 2023-07-07 at 18 15 57
@Ali-Parandeh Ali-Parandeh added the bug Something isn't working label Jul 7, 2023
@Ali-Parandeh Ali-Parandeh changed the title Cannot rename slices without breaking slice machine Cannot rename slices without breaking slice machine - V 1.5.0 Jul 7, 2023
@eraykeskinmac
Copy link

We've been getting the same error since today morning, I think it's because of the next adapter, but I still haven't solved it since I updated the next adapter.

@lihbr lihbr added enhancement New feature or request and removed bug Something isn't working labels Oct 20, 2023
@comeprismic
Copy link

Hi there,

Thanks for your message. The reason why you are getting these errors is that the rename feature does not rename the id that is unique. This is a feature improvement that we know about and will have to do in the future, but this has not been prioritized yet to be transparent.

We will come back here when we re-open the topic.

Best,

Côme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants