Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The initial of 'intermediate' loga #51

Open
secretu opened this issue Nov 1, 2023 · 1 comment
Open

The initial of 'intermediate' loga #51

secretu opened this issue Nov 1, 2023 · 1 comment

Comments

@secretu
Copy link

secretu commented Nov 1, 2023

Hi,
I noticed the initial of the 'intermediate_z' is different from others, which will introduce a initial sparsity in mlp layer. I wonder why did this different initial step.

https://github.com/princeton-nlp/CoFiPruning/blob/da855a809c4a15e1c964a47a37998db2e1a226fd/models/l0_module.py#L147C8-L147C39

https://github.com/princeton-nlp/CoFiPruning/blob/da855a809c4a15e1c964a47a37998db2e1a226fd/models/l0_module.py#L134C9-L134C9

@xiamengzhou
Copy link
Collaborator

Hi, I believe that it's mostly a typo. I also vaguely remember having an initial sparsity does not affect performance much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants