Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change naming of hashes to digest #80

Open
ckartik opened this issue Jan 30, 2024 · 0 comments
Open

Change naming of hashes to digest #80

ckartik opened this issue Jan 30, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@ckartik
Copy link
Contributor

ckartik commented Jan 30, 2024

The image above shows a pre-confirmation payload. You can observe, payloads are iteratively wrapped with integrity perserving hashes that form the digest input to signing operations.

Since hashes can have many use cases and does not provide a descriptive explanation for it's use in the context of the pre-confirmation structure, we should move towards using the word Digest in the context of the payload.

This will be increasingly important, as the commitment hash (to be named commitment digest) will also come to represent BidID in the context of this Update to ensure funds movement with a bid and future features sets centered around canceling and doing further operations on bids.

Using commitment Digest is a useful Bid ID, because:

  1. It is unique to the expression of a Bid by a bidder.
  2. It can be computed client-side by the bidder and any other party, that has access to the Bid Payload (which includes the bidder signature)
drawing
@ckartik ckartik added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant