From e016ca337142be56baca9947f9622947f785d0b9 Mon Sep 17 00:00:00 2001 From: Mateusz Adamczyk <163399256+mateuszstudentzero@users.noreply.github.com> Date: Wed, 16 Oct 2024 09:22:26 +0200 Subject: [PATCH 1/8] Create npm-grunt.yml MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Do ewentualnej modyfikacji w przyszłości --- .github/workflows/npm-grunt.yml | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 .github/workflows/npm-grunt.yml diff --git a/.github/workflows/npm-grunt.yml b/.github/workflows/npm-grunt.yml new file mode 100644 index 00000000000..2ca5379d024 --- /dev/null +++ b/.github/workflows/npm-grunt.yml @@ -0,0 +1,28 @@ +name: NodeJS with Grunt + +on: + push: + branches: [ "master" ] + pull_request: + branches: [ "master" ] + +jobs: + build: + runs-on: ubuntu-latest + + strategy: + matrix: + node-version: [18.x, 20.x, 22.x] + + steps: + - uses: actions/checkout@v4 + + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v4 + with: + node-version: ${{ matrix.node-version }} + + - name: Build + run: | + npm install + grunt From 5016e361f8a614e4bc6cc51b57c1dcc28859fa5c Mon Sep 17 00:00:00 2001 From: Mateusz Adamczyk <163399256+mateuszstudentzero@users.noreply.github.com> Date: Wed, 16 Oct 2024 09:34:26 +0200 Subject: [PATCH 2/8] create an index.html file --- index.html | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 index.html diff --git a/index.html b/index.html new file mode 100644 index 00000000000..e69de29bb2d From 17c822828b9716c72e8722446856dfefe0515f33 Mon Sep 17 00:00:00 2001 From: Mateusz Adamczyk <163399256+mateuszstudentzero@users.noreply.github.com> Date: Wed, 16 Oct 2024 09:46:24 +0200 Subject: [PATCH 3/8] Update index.html --- index.html | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/index.html b/index.html index e69de29bb2d..91a61a10a3b 100644 --- a/index.html +++ b/index.html @@ -0,0 +1,22 @@ +1.Component: RadioButton #16553 +https://github.com/primefaces/primeng/issues/16553 + +Issue:The RadioButton component is not functioning correctly with screen readers. When navigating using only the keyboard, the screen reader does not announce when a radio button is checked + +Requirement: Radiobutton component should work correctly with the screen readers when navigating using only the keyboard. + +2.Component: Carousel accessibility issue #16552 +https://github.com/primefaces/primeng/issues/16552 + +Issue: Aria-hidden element must not be focusable or contain focusable elements. + +Requirement: Aria-hidden should not display or contain is focusable element. The need to examine whether elements are hidden using CSS (e.g. display: none) or ARIA attributes such as aria-hidden to ensure that they are correctly blocked from access. + +3.table inappropriately displays p-column-title of span #16549 +https://github.com/primefaces/primeng/issues/16549 + +Issue: The hidden p-column-title span data is being displayed. + +Requirement: Check the p-column-title span data shouldn't display. + + From a537ea0ee734d6f1da2638480816dadbeb4276a2 Mon Sep 17 00:00:00 2001 From: Mateusz Adamczyk <163399256+mateuszstudentzero@users.noreply.github.com> Date: Wed, 16 Oct 2024 09:55:40 +0200 Subject: [PATCH 4/8] Update index.html --- index.html | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/index.html b/index.html index 91a61a10a3b..743125591d6 100644 --- a/index.html +++ b/index.html @@ -19,4 +19,10 @@ Requirement: Check the p-column-title span data shouldn't display. +4.Tab navigation not getting focussed on Eye icon in ToggleMask Mode +https://github.com/primefaces/primeng/issues/16555 + +Issue: Password: Tab navigation not getting focussed on Eye icon in ToggleMask Mode. + +Requirement: When user has the focus inside input field, and click tab, then the focus should be redirected to the eye-icon. From 080cadbe2c005e3772dc30183371430585606fc7 Mon Sep 17 00:00:00 2001 From: joaanyk Date: Fri, 22 Nov 2024 09:44:30 +0100 Subject: [PATCH 5/8] Fix: Add ripple effect to AccordionTab header --- .github/workflows/npm-grunt.yml | 28 ----------------------- index.html | 28 ----------------------- src/app/components/accordion/accordion.ts | 1 + src/index.html | 25 -------------------- 4 files changed, 1 insertion(+), 81 deletions(-) delete mode 100644 .github/workflows/npm-grunt.yml delete mode 100644 index.html delete mode 100755 src/index.html diff --git a/.github/workflows/npm-grunt.yml b/.github/workflows/npm-grunt.yml deleted file mode 100644 index 2ca5379d024..00000000000 --- a/.github/workflows/npm-grunt.yml +++ /dev/null @@ -1,28 +0,0 @@ -name: NodeJS with Grunt - -on: - push: - branches: [ "master" ] - pull_request: - branches: [ "master" ] - -jobs: - build: - runs-on: ubuntu-latest - - strategy: - matrix: - node-version: [18.x, 20.x, 22.x] - - steps: - - uses: actions/checkout@v4 - - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v4 - with: - node-version: ${{ matrix.node-version }} - - - name: Build - run: | - npm install - grunt diff --git a/index.html b/index.html deleted file mode 100644 index 743125591d6..00000000000 --- a/index.html +++ /dev/null @@ -1,28 +0,0 @@ -1.Component: RadioButton #16553 -https://github.com/primefaces/primeng/issues/16553 - -Issue:The RadioButton component is not functioning correctly with screen readers. When navigating using only the keyboard, the screen reader does not announce when a radio button is checked - -Requirement: Radiobutton component should work correctly with the screen readers when navigating using only the keyboard. - -2.Component: Carousel accessibility issue #16552 -https://github.com/primefaces/primeng/issues/16552 - -Issue: Aria-hidden element must not be focusable or contain focusable elements. - -Requirement: Aria-hidden should not display or contain is focusable element. The need to examine whether elements are hidden using CSS (e.g. display: none) or ARIA attributes such as aria-hidden to ensure that they are correctly blocked from access. - -3.table inappropriately displays p-column-title of span #16549 -https://github.com/primefaces/primeng/issues/16549 - -Issue: The hidden p-column-title span data is being displayed. - -Requirement: Check the p-column-title span data shouldn't display. - -4.Tab navigation not getting focussed on Eye icon in ToggleMask Mode - -https://github.com/primefaces/primeng/issues/16555 - -Issue: Password: Tab navigation not getting focussed on Eye icon in ToggleMask Mode. - -Requirement: When user has the focus inside input field, and click tab, then the focus should be redirected to the eye-icon. diff --git a/src/app/components/accordion/accordion.ts b/src/app/components/accordion/accordion.ts index f4759c232f5..2d3143ac437 100755 --- a/src/app/components/accordion/accordion.ts +++ b/src/app/components/accordion/accordion.ts @@ -43,6 +43,7 @@ import { UniqueComponentId } from 'primeng/utils'; [ngStyle]="headerStyle" role="button" class="p-accordion-header-link" + pRipple (click)="toggle($event)" (keydown)="onKeydown($event)" [attr.tabindex]="disabled ? null : 0" diff --git a/src/index.html b/src/index.html deleted file mode 100755 index d58b939b41b..00000000000 --- a/src/index.html +++ /dev/null @@ -1,25 +0,0 @@ - - - - PrimeNG - - - - - - - - - - - - - - -
-
- -
- - - From c0f507eadfc113e9bf75a6de91b849a205f67781 Mon Sep 17 00:00:00 2001 From: joaanyk Date: Fri, 22 Nov 2024 09:45:40 +0100 Subject: [PATCH 6/8] Restore index.html --- src/index.html | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100755 src/index.html diff --git a/src/index.html b/src/index.html new file mode 100755 index 00000000000..d58b939b41b --- /dev/null +++ b/src/index.html @@ -0,0 +1,25 @@ + + + + PrimeNG + + + + + + + + + + + + + + +
+
+ +
+ + + From 421ad6371c6fb37c6682c791ff5e6273ecca18c9 Mon Sep 17 00:00:00 2001 From: mateuszstudentzero <71056@student.pb.edu.pl> Date: Fri, 22 Nov 2024 10:33:00 +0100 Subject: [PATCH 7/8] Fix: Dropdown respects emitEvent=false when setting value (#16755) --- src/app/components/dropdown/dropdown.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/app/components/dropdown/dropdown.ts b/src/app/components/dropdown/dropdown.ts index ad850070529..6595fdd2b8c 100755 --- a/src/app/components/dropdown/dropdown.ts +++ b/src/app/components/dropdown/dropdown.ts @@ -1208,13 +1208,15 @@ export class Dropdown implements OnInit, AfterViewInit, AfterContentInit, AfterV this.selectedOptionUpdated = true; } - writeValue(value: any): void { + writeValue(value: any, emitEvent: boolean = true): void { if (this.filter) { this.resetFilter(); } this.value = value; - this.allowModelChange() && this.onModelChange(value); + if (emitEvent && this.allowModelChange()) { + this.onModelChange(value); + } this.modelValue.set(this.value); this.updateEditableLabel(); this.cd.markForCheck(); From 0480490198df53d726f733f05007fcda6cccc105 Mon Sep 17 00:00:00 2001 From: mateuszstudentzero <71056@student.pb.edu.pl> Date: Fri, 22 Nov 2024 10:37:20 +0100 Subject: [PATCH 8/8] Drop uneccessary changes --- src/app/components/accordion/accordion.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/app/components/accordion/accordion.ts b/src/app/components/accordion/accordion.ts index 2d3143ac437..f4759c232f5 100755 --- a/src/app/components/accordion/accordion.ts +++ b/src/app/components/accordion/accordion.ts @@ -43,7 +43,6 @@ import { UniqueComponentId } from 'primeng/utils'; [ngStyle]="headerStyle" role="button" class="p-accordion-header-link" - pRipple (click)="toggle($event)" (keydown)="onKeydown($event)" [attr.tabindex]="disabled ? null : 0"