-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved CSG filling strategies #288
base: main
Are you sure you want to change the base?
Conversation
Add changelog file
…local trend based filling strategy
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
==========================================
+ Coverage 96.70% 96.94% +0.23%
==========================================
Files 49 54 +5
Lines 4710 5205 +495
==========================================
+ Hits 4555 5046 +491
- Misses 155 159 +4 ☔ View full report in Codecov by Sentry. |
…y not complete yet).
…ed bugfix from primap2 code
…upstream development versions CI run due to unresolved dependencies
… of the upstream development versions CI run due to unresolved dependencies" This reverts commit 79efd3f.
…lating scaling factors)
Co-authored-by: Mika Pflüger <[email protected]>
Ready for review. Docs still to come, but that should be quick as the class docstring is quite detailed. |
fill_ts: xr.DataArray, | ||
gap: Gap, | ||
factor: np.array, | ||
) -> xr.DataArray: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
) -> xr.DataArray: | |
) -> xr.DataArray: | |
"""Fill a gap in a timeseries using data from another timeseries and factors. | |
Parameters | |
---------- | |
ts: xr.DataArray | |
Timeseries with a gap to be filled. | |
fill_ts: xr.DataArray | |
Timeseries from which to take the data to fill in the gap in ts. | |
gap: Gap | |
The gap that should be filled. | |
factor: np.array | |
Numpy array containing two floats, the scaling factor to use at the left side of the gap | |
and the scaling factor to use at the right side of the gap. The data from fill_ts will be | |
multiplied with the factor before filling the gap in ts. If the factors differ, a linear | |
interpolation of the scaling factor between both values will be performed. | |
Returns | |
----------- | |
result | |
DataArray with the same size and shape as ts, but with the given gap filled from fill_ts. | |
""" |
Pull request
Please confirm that this pull request has done the following:
{pr}.thing.md
file in the directorychangelog
added - see changelog/README.md for detailsDescription
Add more filling strategies for the csg
Important
Merge #286 first