Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

would STFT be in scope for this project #6

Closed
skewballfox opened this issue May 13, 2023 · 2 comments
Closed

would STFT be in scope for this project #6

skewballfox opened this issue May 13, 2023 · 2 comments

Comments

@skewballfox
Copy link

Hi, Currently I'm porting librosa's implementation of an STFT function to rust, though I wonder whether or not that would be something worth adding directly to this project. This is a branch of math I'm not too familiar with, so I'm not sure if it's in scope for what this library is meant to provide or if it's more of a thing meant to be built on top of this library

@preiter93
Copy link
Owner

Hey, it doesnt quite fit the idea of this library which is to make multidimensional transforms easier by combining ndarray + rustfft/realfft/rustdct.

I think a stft could be its own crate (build on top of rustfft)

@skewballfox
Copy link
Author

I have an stft implementation implemented in my crate. It's linked in the related issue. It's only for arrays of 1 and 2 dims, currently has a hardset window function, and currently only accepts f32s, though all of those things can be iterativley improved.

I guess I'm wondering is this something that would actually be useful to people or would it take a tremendous amount of effort to iterate to the point that it benefits more than say 5 people solving the exact same problem? I don't have a signal processing background so I'm still unsure of the scope of the utility I guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants