Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support numpy >= 2 ? #176

Closed
BenjaminRodenberg opened this issue Aug 19, 2024 · 3 comments
Closed

Support numpy >= 2 ? #176

BenjaminRodenberg opened this issue Aug 19, 2024 · 3 comments
Assignees
Labels
compatibility wontfix This will not be worked on
Milestone

Comments

@BenjaminRodenberg
Copy link
Member

BenjaminRodenberg commented Aug 19, 2024

We currently do not support numpy >= 2. I, consequently, restricted numpy to numpy < 2 in #175. Ensuring compatibility for newer numpy versions (and occasionally dropping numpy 1 support) is definitely a future todo.

Remark:

@BenjaminRodenberg BenjaminRodenberg changed the title Support numpy >= 2 Support numpy >= 2 ? Aug 19, 2024
@BenjaminRodenberg
Copy link
Member Author

Note that we are currently fixing support for numpy >= 2 in pyprecice (precice/python-bindings#218). Therefore, it might be possible to easily support numpy >= 2 here as well. This requires some testing but would also give us additional flexibility for downstream projects.

@NiklasVin
Copy link
Collaborator

NiklasVin commented Sep 19, 2024

Since FEniCS (without the x) is at it's end of life, we might also just stay with numpy version 1 and make this issue a `wontfix`.

I tried to solve the plain heat equation (so no partitioning) with FEniCS and numpy version 2.0.0 and got the following error: ValueError: could not convert string to float: 'np.float64(-1.0)'.
In this discussion on the FEniCS discourse, the same error occured and it seems like the numpy version is the issue.
Hence, I would say that supporting numpy >= 2 for the fenicsprecice adapter isn't possible, or makes no sense at least.

@NiklasVin NiklasVin added the wontfix This will not be worked on label Oct 19, 2024
@BenjaminRodenberg
Copy link
Member Author

Closing this issue. This is another argument for prioritizing FEniCS-X on the long run.

@uekerman uekerman closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants