Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preact-iso's types with TS's "NodeNext" resolution #947

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rschristian
Copy link
Member

TS with "moduleResolution": "NodeNext" will fail to resolve preact-iso's types as they don't use the .js extension in their imports to reference the .d.ts files.

@changeset-bot
Copy link

changeset-bot bot commented Dec 31, 2022

🦋 Changeset detected

Latest commit: d96f58b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
preact-iso Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 31, 2022

Size Change: 0 B

Total Size: 6.37 kB

ℹ️ View Unchanged
Filename Size
packages/preact-iso/.dist/index.********.js 1.71 kB
packages/preact-iso/.dist/prerender.********.js 377 B
packages/preact-iso/hydrate.js 290 B
packages/preact-iso/index.js 195 B
packages/preact-iso/lazy.js 594 B
packages/preact-iso/prerender.js 656 B
packages/preact-iso/router.js 2.54 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant