Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove journal from required elements in reference field #79

Merged
merged 3 commits into from
Oct 2, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Conda builds are now noarch - one package for all Pythons!
- pip installs now require Python compatible with 3.5
- Appveyor runs a single job and no longer builds conda packages
- Remove journal from required fields in the reference

## [0.2.1] - 2017-08-31
### Fixed
Expand Down
1 change: 0 additions & 1 deletion pyked/schemas/chemked_schema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ reference:
min: 0
type: integer
journal:
required: true
type: string
doi:
type: string
Expand Down
2 changes: 1 addition & 1 deletion pyked/tests/test_validation.py
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ def test_missing_required_field(self, field, properties):
assert v.errors[field][0] == 'required field'

@pytest.mark.parametrize("field, sub", [
('reference', 'authors'), ('reference', 'journal'), ('reference', 'year'),
('reference', 'authors'), ('reference', 'year'),
('apparatus', 'kind'), ('file-author', 'name'),
])
@pytest.mark.parametrize("properties", ['testfile_required.yaml'], indirect=["properties"])
Expand Down
1 change: 0 additions & 1 deletion pyked/tests/testfile_required.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ chemked-version: 0.0.1
reference:
authors:
- name: A. Author
journal: Testing Journal
year: 1600
experiment-type: ignition delay
apparatus:
Expand Down