Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove journal from required elements in reference field #79

Merged
merged 3 commits into from
Oct 2, 2017
Merged

Remove journal from required elements in reference field #79

merged 3 commits into from
Oct 2, 2017

Conversation

bryanwweber
Copy link
Member

Closes #76

Changes proposed in this pull request:

  • Remove journal from required elements in reference field

@pr-omethe-us/chemked

@bryanwweber
Copy link
Member Author

Again, the tests are failing because of problems fixed in #77. Not sure why Appveyor didn't fail...

@kyleniemeyer
Copy link
Member

Now that #77 is merged, can we trigger the tests to run again here?

@kyleniemeyer kyleniemeyer reopened this Oct 2, 2017
@codecov
Copy link

codecov bot commented Oct 2, 2017

Codecov Report

Merging #79 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #79   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         851    851           
  Branches      202    202           
=====================================
  Hits          851    851

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e99096a...1c5b9ed. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 2, 2017

Codecov Report

Merging #79 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #79   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         851    851           
  Branches      202    202           
=====================================
  Hits          851    851

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e99096a...1c5b9ed. Read the comment docs.

@kyleniemeyer kyleniemeyer merged commit fb8776d into pr-omethe-us:master Oct 2, 2017
@bryanwweber bryanwweber deleted the remove_journal_req branch October 4, 2017 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants