You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At L190 of validation.py, we check the provided ORCID against the ORCID that is optionally provided from the CrossRef database. I would argue this check is unnecessary and will lead to false-warnings. We already validate the provided ORCID separately... if we want to suggest to users that they provide the ORCID of a paper author, we should do that in that validation function. That said, I don't think that we should provide this suggestion at all, since many more authors are not going to have ORCIDs than have them, unless we search the ORCID database and provide possible ORCIDs for the authors who are missing them. If we do provide the suggestion, it should be possible to turn it off as well.
The text was updated successfully, but these errors were encountered:
I agree checking the DOI-based ORCID with provided ORCID isn't strictly necessary, but if the file doesn't provide ORCID (when there is one easily available from the reference DOI) then I do think we should suggest adding it in this location—mainly because I absolutely don't want to search for ORCID based on name.
I want to encourage including ORCID in the files, and since we basically get them "for free" with the DOI (occasionally, at least...) I'd like to keep this.
Actually, when we extend DOI support to DataCite DOIs ( #9 ), any such references will be more likely to have associated ORCIDs, since I think people using Zenodo and Figshare would be more likely to have those associated with their accounts (no reference to back this up).
OK, so I think the agreed to-do here is to allow disabling these warning messages.
I do still want to keep the check of provided ORCID vs. what the DOI returns, if only to give a correct value such that the file can be updated. The separate ORCID validation will not do that, just check that the given name matches what's in the system for the given ORCID.
At L190 of
validation.py
, we check the provided ORCID against the ORCID that is optionally provided from the CrossRef database. I would argue this check is unnecessary and will lead to false-warnings. We already validate the provided ORCID separately... if we want to suggest to users that they provide the ORCID of a paper author, we should do that in that validation function. That said, I don't think that we should provide this suggestion at all, since many more authors are not going to have ORCIDs than have them, unless we search the ORCID database and provide possible ORCIDs for the authors who are missing them. If we do provide the suggestion, it should be possible to turn it off as well.The text was updated successfully, but these errors were encountered: