Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Plugin is render-blocking #1264

Open
LynanBreeze opened this issue Jan 15, 2024 · 0 comments
Open

Comment Plugin is render-blocking #1264

LynanBreeze opened this issue Jan 15, 2024 · 0 comments
Labels
bug:extension Issues about widgets, comment, share, search, and plugins.

Comments

@LynanBreeze
Copy link

LynanBreeze commented Jan 15, 2024

Bug描述
When comment plugin loads its .js and .css files, widgets on the left would not be shown until comment plugin files are loaded.
当评论插件加载.js.css文件时,左侧的Widgets被阻塞渲染。

系统与环境

themes/icarus/layout/layout.jsx
https://github.com/ppoffice/hexo-theme-icarus/blob/master/layout/layout.jsx#L32

<div class={classname({
    column: true,
    'order-2': true,
    'column-main': true,
    'is-12': columnCount === 1,
    'is-8-tablet is-8-desktop is-9-widescreen': columnCount === 2,
    'is-8-tablet is-8-desktop is-6-widescreen': columnCount === 3
})} dangerouslySetInnerHTML={{ __html: body }}></div> // Blocking when loading comment plugin
<Widgets site={site} config={config} helper={helper} page={page} position={'left'} />
<Widgets site={site} config={config} helper={helper} page={page} position={'right'} />

期望行为
Widgets would not be blocked by comment plugin.
左侧Widgets可以在页面打开时正确展示。

截图
image
image

@ppoffice ppoffice added the bug:extension Issues about widgets, comment, share, search, and plugins. label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:extension Issues about widgets, comment, share, search, and plugins.
Projects
None yet
Development

No branches or pull requests

2 participants