From 50ed5438582e639f26de80d82f33aea4d04f822e Mon Sep 17 00:00:00 2001 From: Cameron White Date: Sun, 29 Sep 2024 13:54:50 -0400 Subject: [PATCH] Avoid using the homebrew qt6 which doesn't work with macdeployqt --- .github/workflows/build.yml | 12 ++++++++++-- README.md | 1 + 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 28a90158..c76b1e46 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -47,9 +47,17 @@ jobs: rm /usr/local/bin/idle3* rm /usr/local/bin/pydoc3* rm /usr/local/bin/python3* - brew install --overwrite boost cmake doctest minizip ninja nlohmann-json pugixml qt6 pugixml rtmidi + brew install --overwrite boost cmake doctest minizip ninja nlohmann-json pugixml pugixml rtmidi + + # Note: we avoid using the homebrew Qt since it breaks macdeployqt (https://github.com/Homebrew/brew/issues/15354) + - name: Install Qt + uses: jurplel/install-qt-action@v4 + with: + arch: clang_64 + version: 6.7.2 + - name: Generate Project - run: cmake -S ${GITHUB_WORKSPACE} -B ${{runner.workspace}}/build -G Ninja -DCMAKE_BUILD_TYPE=Release -DCMAKE_PREFIX_PATH=/usr/local/opt/qt6/lib/cmake + run: cmake -S ${GITHUB_WORKSPACE} -B ${{runner.workspace}}/build -G Ninja -DCMAKE_BUILD_TYPE=Release - name: Build run: cmake --build ${{runner.workspace}}/build - name: Test diff --git a/README.md b/README.md index c42b053a..13503cbd 100644 --- a/README.md +++ b/README.md @@ -131,6 +131,7 @@ You'll have to update the variables for your specific paths to `$vcpkg_exe_path` * Install Xcode along with its Command Line Tools. * Install dependencies: * `brew install boost cmake doctest minizip ninja nlohmann-json pugixml qt6 pugixml rtmidi` + * Note that the Qt package from homebrew [does not currently work for building the installer|https://github.com/Homebrew/brew/issues/15354]. Installing via https://github.com/miurahr/aqtinstall is an alternative. * Build: * `mkdir build && cd build` * `cmake -G Ninja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_PREFIX_PATH=/usr/local/opt/qt6/lib/cmake ..`