Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old permission columns from project table #997

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

dancoates
Copy link
Contributor

@dancoates dancoates commented Nov 26, 2024

After the last permissions update, we no longer need the group ids and names in the project table. All permissions are managed by the project members table now.

Note: we'd not normally want to remove columns as it affects the ability to query the system versioned tables for history of those columns. In this case it is ok as we have permission changes recorded in cpg-infra, and we're not actively using the permission history anywhere.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.75%. Comparing base (9b7f2de) to head (42d0b69).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #997   +/-   ##
=======================================
  Coverage   81.75%   81.75%           
=======================================
  Files         184      184           
  Lines       15969    15969           
=======================================
  Hits        13056    13056           
  Misses       2913     2913           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dancoates dancoates merged commit 99ceccd into dev Nov 26, 2024
9 checks passed
@dancoates dancoates deleted the SET-265-clean-up-old-metamist-permissions-tables branch November 26, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants