Refactor test subset script and add test cases #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reformatted the create_test_subset.py script with a class definition for TestSubsetGenerator. I basically just moved the existing code into class methods and cleaned up the main function by calling the various class methods. I also added in a locally defined random seed so that the random seeding is consistent for the test cases.
I made a start on the test cases, however I'm a little stuck on testing the transferring of participants into the test project. In the test cases, the default project created is "test". I think creating a project called "test-test" to test this script is fine (albeit a little confusing), but I've not been able to get the create_project() method working from the project permissions table.