Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

Consul backend std.py is not resilient to connection errors #30

Open
ShaheedHaque opened this issue Feb 20, 2021 · 0 comments · May be fixed by #31
Open

Consul backend std.py is not resilient to connection errors #30

ShaheedHaque opened this issue Feb 20, 2021 · 0 comments · May be fixed by #31

Comments

@ShaheedHaque
Copy link

The std.py backend currently does not attempt any connection retries, so even the occasional network transient makes it rather fragile. It would be useful if some provision for retries were added.

I will shortly file a PR proposing a fix for this.
ShaheedHaque added a commit to ShaheedHaque/python-consul2 that referenced this issue Feb 20, 2021
@ShaheedHaque
Resolves poppyred#30. Enable retries in the std.py backend. This PR a…
c4ebfc5 
…lso:

- Replaces the deprecated call to requests.session() with its
  current counterpart, requests.Session().
- Allows arbitrary connection kwargs to be passed down, not least
  to allow the new retry behaviour to be overridden.
@ShaheedHaque ShaheedHaque linked a pull request Feb 20, 2021 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable retries in the std.py backend. ShaheedHaque/python-consul2
1 participant
@ShaheedHaque