From c63b9263aebf685b3411db5f46ad7fddbc3a5452 Mon Sep 17 00:00:00 2001
From: Yan Pujante <ypujante@gmail.com>
Date: Sun, 6 Jan 2019 11:11:20 -0800
Subject: [PATCH] fixed minor issues

---
 README.md                                        | 3 +++
 jamba.cmake                                      | 2 +-
 src/cpp/pongasoft/Utils/Constants.h              | 3 ++-
 src/cpp/pongasoft/VST/AudioBuffer.h              | 2 +-
 src/cpp/pongasoft/VST/GUI/Params/GUIParamCxMgr.h | 9 ++++-----
 src/cpp/pongasoft/VST/GUI/ViewCxMgr.h            | 2 +-
 6 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/README.md b/README.md
index 6a1b3a3..5a7183e 100644
--- a/README.md
+++ b/README.md
@@ -202,6 +202,9 @@ Documentation
 
 Release Notes
 -------------
+### 2019-01-06 - `v3.0.2`
+* fixed minor bugs
+
 ### 2019-01-04 - `v3.0.1`
 * Use shallow cloning to avoid downloading the (unused) project history
 
diff --git a/jamba.cmake b/jamba.cmake
index 6fe8f61..9476a41 100644
--- a/jamba.cmake
+++ b/jamba.cmake
@@ -6,7 +6,7 @@ set(JAMBA_ROOT ${CMAKE_CURRENT_LIST_DIR})
 #-------------------------------------------------------------------------------
 set(JAMBA_MAJOR_VERSION 3)
 set(JAMBA_MINOR_VERSION 0)
-set(JAMBA_PATCH_VERSION 1)
+set(JAMBA_PATCH_VERSION 2)
 execute_process(COMMAND git describe --long --dirty --abbrev=10 --tags
     RESULT_VARIABLE result
     OUTPUT_VARIABLE JAMBA_GIT_VERSION
diff --git a/src/cpp/pongasoft/Utils/Constants.h b/src/cpp/pongasoft/Utils/Constants.h
index 61e2a0a..3154c5c 100644
--- a/src/cpp/pongasoft/Utils/Constants.h
+++ b/src/cpp/pongasoft/Utils/Constants.h
@@ -15,13 +15,14 @@
  *
  * @author Yan Pujante
  */
-
+#pragma once
 #include <pluginterfaces/base/ftypes.h>
 
 namespace pongasoft {
 namespace Utils {
 
 constexpr Steinberg::int32 MAX_INT32 = 0x7fffffff;
+constexpr auto ZERO_INT32 = static_cast<Steinberg::int32>(0);
 
 }
 }
\ No newline at end of file
diff --git a/src/cpp/pongasoft/VST/AudioBuffer.h b/src/cpp/pongasoft/VST/AudioBuffer.h
index 07f1ba9..54472b4 100644
--- a/src/cpp/pongasoft/VST/AudioBuffer.h
+++ b/src/cpp/pongasoft/VST/AudioBuffer.h
@@ -343,7 +343,7 @@ class AudioBuffers
     }
 
     if(getNumChannels() > 0)
-      fBuffer.silenceFlags == (static_cast<uint64>(1) << getNumChannels()) - 1;
+      fBuffer.silenceFlags = (static_cast<uint64>(1) << getNumChannels()) - 1;
 
     return kResultOk;
   }
diff --git a/src/cpp/pongasoft/VST/GUI/Params/GUIParamCxMgr.h b/src/cpp/pongasoft/VST/GUI/Params/GUIParamCxMgr.h
index 3fd93ca..b3daedd 100644
--- a/src/cpp/pongasoft/VST/GUI/Params/GUIParamCxMgr.h
+++ b/src/cpp/pongasoft/VST/GUI/Params/GUIParamCxMgr.h
@@ -190,16 +190,15 @@ class GUIParamCxMgr
   }
 
   /**
- * Registers the ser param only given its id and return the wrapper to the param.
- *
- * @return the wrapper which may be empty if the param does not exists or is of wrong type (use .exists)
- */
+   * Registers the ser param only given its id and return the wrapper to the param.
+   *
+   * @return the wrapper which may be empty if the param does not exists or is of wrong type (use .exists)
+   */
   template<typename T>
   GUIJmbParam<T> registerJmbCallback(ParamID iParamID,
                                      Parameters::ChangeCallback iChangeCallback,
                                      bool iInvokeCallback)
   {
-    return __registerJmbParam<T>(iParamID, std::move(iChangeCallback));
     return maybeInvokeCallback(__registerJmbParam<T>(iParamID, iChangeCallback),
                                iChangeCallback,
                                iInvokeCallback);
diff --git a/src/cpp/pongasoft/VST/GUI/ViewCxMgr.h b/src/cpp/pongasoft/VST/GUI/ViewCxMgr.h
index 0365628..127d938 100644
--- a/src/cpp/pongasoft/VST/GUI/ViewCxMgr.h
+++ b/src/cpp/pongasoft/VST/GUI/ViewCxMgr.h
@@ -88,7 +88,7 @@ class ViewCxMgr : private IViewListenerAdapter
 {
 public:
   /**
-   * @param TView should be a subclass of VSTGUI::CView
+   * @tparam TView should be a subclass of VSTGUI::CView
    * @return a pointer (owned by this class) to an object for registering callbacks, listener and params.
    *         Note: You should not keep this pointer around. It is owned by this class and will automatically be deleted
    *         when the view goes away.