Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synced events not filtered to Factory contract instantiations. #1358

Open
jwahdatehagh opened this issue Dec 18, 2024 · 2 comments
Open

Synced events not filtered to Factory contract instantiations. #1358

jwahdatehagh opened this issue Dec 18, 2024 · 2 comments

Comments

@jwahdatehagh
Copy link
Contributor

Version

0.8.7

Current behavior

In my production installation on v7, the only contract events from the collection contracts created via the factory are tracked.

Expected behavior

After the upgrade to v8, i get random events (generally matching the contract ABI) from contracts that were not created via my configured factory.

Steps to reproduce

Reproduction example: https://github.com/visualizevalue/mint/tree/feature/indexer%400.8/indexer

(On the v8 feature branch)

Link to repository

https://github.com/visualizevalue/mint/tree/feature/indexer%400.8/indexer

Anything else?

No response

@typedarray
Copy link
Collaborator

Thanks for opening. Did you run this app using version 0.8.0 - 0.8.4 against the same database? There was an issue in those versions where eth_getLogs requests to certain RPC providers returning incorrect logs, which could be cached in your database.

@jwahdatehagh
Copy link
Contributor Author

i tried both against fresh/empty databases and the synced 0.7 database and with versions 0.8.2 - 0.8.7; problem persisted regardless.

i get ERC1155 events from contracts that were not created via the configured factory...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants