Support Wallet Connect #243
Conversation
|
Scheduled for v15.3 |
| @@ -89,7 +89,7 @@ const RestoreByScan = ({ isActive, onComplete, onCancel }) => { | |||
| f() | |||
| }, [addressInput]) | |||
|
|
|||
| const onScan = async (e, isJson) => { | |||
| const onScan = async (e, { isJson }) => { | |||
There was a problem hiding this comment.
This is causing restore by scanning seed QR code to silently fail
| message.error('You can only upload JSON or JPG/PNG file') | ||
| const isSupported = ['image/jpeg', 'image/png', ...supportedNonImgFiles].includes(file.type) | ||
| if (!isSupported) { | ||
| message.error(`You can only upload JPG/PNG ${supportedNonImgFiles.length ? `or ${supportedNonImgFiles.join(',')} ` : ''}file`) |
There was a problem hiding this comment.
application/json is too technical for notifications
|
Can you construct some minimal testing examples? |
…o missing object argument
taoalpha
force-pushed
the
taoalpha/walletconnect
branch
from
7690825 to
7577179
Compare
| <Divider /> | ||
| <Title level={3}>Auth</Title> | ||
| <Space wrap> | ||
| <Button type='primary' shape='round' href='/auth/walletconnect'>Wallet Connect</Button> |
There was a problem hiding this comment.
This is quite hidden. Probably not the best place to put it. Any suggestions for better place?
|
Will continue the implementation after #281 is partially done |
# Conflicts: # code/client/package.json # code/client/src/app.less # code/client/src/integration/Common.jsx
|
WalletConnect client v1 is deprecated https://www.npmjs.com/package/@walletconnect/client, so I will rewrite this with their latest SDK https://docs.walletconnect.com/web3wallet/about |
…ct; refactor some rpc calls and add more
|
Works now end-to-end. Tested with multisig.harmony.one. Should add state persistence to outstanding, unacknowledged requests. Will do it later. |
tested with https://example.walletconnect.org/
This is for #193