Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purchase NFT in Harmony daVinci marketplace directly from wallet #61

Closed
polymorpher opened this issue Jul 28, 2021 · 2 comments
Closed

Comments

@polymorpher
Copy link
Owner

This requires an implementation of EIP-1271 (https://eips.ethereum.org/EIPS/eip-1271) and corresponding support from daVinci marketplace smart contract. I am waiting for the repository owners to respond.

https://github.com/harmony-one/davinci_nft_marketplace/blob/040514b07ce8f8047daca4b67cd9156ff58af937/contracts/exchange/ExchangeV1.sol#L114

https://github.com/harmony-one/davinci_nft_marketplace/blob/040514b07ce8f8047daca4b67cd9156ff58af937/contracts/exchange/ExchangeV1.sol#L125

@polymorpher polymorpher changed the title Purchase NFT in daVinci marketplace directly from wallet Purchase NFT in Harmony daVinci marketplace directly from wallet Jul 28, 2021
@polymorpher
Copy link
Owner Author

polymorpher commented Sep 2, 2021

Upon reviewing updated code from daVinci, I confirm EIP-1271 and contract change on daVinci are no longer required.

To speed up integration, we will first enable NFT purchase directly from 1wallet. This will be released as part of the update in #94 . Later, we will add 1wallet as an option to connect in daVinci UI use the proper integration flow as discussed in #73 and https://github.com/polymorpher/one-wallet/wiki/App-Integration

@polymorpher
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant