Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardcoded "github.com" in build script #1144

Open
Hugo-Trentesaux opened this issue Jul 22, 2024 · 0 comments
Open

hardcoded "github.com" in build script #1144

Hugo-Trentesaux opened this issue Jul 22, 2024 · 0 comments

Comments

@Hugo-Trentesaux
Copy link

Trying to use build script outside of github, failing on this:

https://github.com/polkadot-js/dev/blob/master/packages/dev/scripts/polkadot-dev-build-ts.mjs#L1421-L1423

const repoPath = pkg.repository.url
  .split('https://github.com/')[1]
  .split('.git')[0];

🤮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant