-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ParaRegistration proxy to Polkadot and Kusama #520
base: main
Are you sure you want to change the base?
ParaRegistration proxy to Polkadot and Kusama #520
Conversation
@@ -1247,6 +1249,12 @@ impl InstanceFilter<RuntimeCall> for ProxyType { | |||
RuntimeCall::System(frame_system::Call::remark { .. }) | | |||
RuntimeCall::System(frame_system::Call::remark_with_event { .. }) | |||
), | |||
ProxyType::ParaRegistration => matches!( | |||
c, | |||
RuntimeCall::Registrar(paras_registrar::Call::reserve { .. }) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need batch or similar as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't. Reserve and Register happen at two different moments in time (in the middle you build the wasm and genesis), so we don't batch both transactions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And register batched with remove proxy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not being used right now, but I still think it could be useful down the line. I just added the Utilities pallet as well for this proxy type.
@@ -1007,6 +1007,7 @@ pub enum ProxyType { | |||
CancelProxy = 6, | |||
Auction = 7, | |||
NominationPools = 8, | |||
ParaRegistration = 9, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be worth making this also 10 so the encoding is the same between Kusama and Polkadot? (Basti probably disagrees with me on this!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha :P Yeah, I don't see any reason for this. They are already different and they are highly chain specific any way.
Review required! Latest push from author must always be reviewed |
@@ -1007,6 +1007,7 @@ pub enum ProxyType { | |||
CancelProxy = 6, | |||
Auction = 7, | |||
NominationPools = 8, | |||
ParaRegistration = 9, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha :P Yeah, I don't see any reason for this. They are already different and they are highly chain specific any way.
/merge |
Enabled Available commands
For more information see the documentation |
This adds a new type of Proxy called ParaRegistration to both Kusama and Polkadot's runtime. This change aids the development of deployment portals that want to execute actions related to deploying parachains.
The allowed actions on this proxy are: