Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParaRegistration proxy to Polkadot and Kusama #520

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

SBalaguer
Copy link
Contributor

This adds a new type of Proxy called ParaRegistration to both Kusama and Polkadot's runtime. This change aids the development of deployment portals that want to execute actions related to deploying parachains.

The allowed actions on this proxy are:

  1. Reserving a paraID.
  2. Registering a Parachain.
  3. Removing proxy.

@@ -1247,6 +1249,12 @@ impl InstanceFilter<RuntimeCall> for ProxyType {
RuntimeCall::System(frame_system::Call::remark { .. }) |
RuntimeCall::System(frame_system::Call::remark_with_event { .. })
),
ProxyType::ParaRegistration => matches!(
c,
RuntimeCall::Registrar(paras_registrar::Call::reserve { .. }) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need batch or similar as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't. Reserve and Register happen at two different moments in time (in the middle you build the wasm and genesis), so we don't batch both transactions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And register batched with remove proxy?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not being used right now, but I still think it could be useful down the line. I just added the Utilities pallet as well for this proxy type.

CHANGELOG.md Outdated Show resolved Hide resolved
@@ -1007,6 +1007,7 @@ pub enum ProxyType {
CancelProxy = 6,
Auction = 7,
NominationPools = 8,
ParaRegistration = 9,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth making this also 10 so the encoding is the same between Kusama and Polkadot? (Basti probably disagrees with me on this!)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha :P Yeah, I don't see any reason for this. They are already different and they are highly chain specific any way.

@github-actions github-actions bot requested review from bkchr and seadanda December 24, 2024 13:40
Copy link

Review required! Latest push from author must always be reviewed

@@ -1007,6 +1007,7 @@ pub enum ProxyType {
CancelProxy = 6,
Auction = 7,
NominationPools = 8,
ParaRegistration = 9,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha :P Yeah, I don't see any reason for this. They are already different and they are highly chain specific any way.

@bkchr
Copy link
Contributor

bkchr commented Dec 25, 2024

/merge

@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) December 25, 2024 21:21
@bkchr bkchr disabled auto-merge December 25, 2024 22:49
relay/kusama/src/lib.rs Outdated Show resolved Hide resolved
relay/polkadot/src/lib.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants