Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for cmd bot #448

Merged

Conversation

mordamax
Copy link
Contributor

@mordamax mordamax commented Aug 30, 2024

  • Does not require a CHANGELOG entry

the issue_comment works from the refs/main branch by default, and doesn't bring the PR context anyhow. Since i was testing it from the default branch in paritytech-stg - it was working fine, but from real PR non-default branch it didn't push result to PR branch.

env:
JOB_NAME: 'cmd'
PR_BRANCH: ${{ needs.get-pr-branch.outputs.pr-branch }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this being used?

Copy link
Contributor Author

@mordamax mordamax Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nowhere, thought to use it but then didn't )) will remove, thanks

.github/workflows/cmd.yml Outdated Show resolved Hide resolved
@mordamax
Copy link
Contributor Author

/merge

@github-actions github-actions bot requested review from bkchr and ggwpez August 30, 2024 10:48
Copy link

Review required! Latest push from author must always be reviewed

@bkchr
Copy link
Contributor

bkchr commented Aug 30, 2024

/merge

@fellowship-merge-bot
Copy link
Contributor

Auto-Merge-Bot

Command `` not recognized.

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) August 30, 2024 11:16
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot merged commit 2d9e568 into polkadot-fellows:main Aug 30, 2024
46 of 48 checks passed
@mordamax mordamax deleted the mordamax-patch-1 branch October 15, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants